Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fcda-binding-list test fails #1257

Closed
Stef3st opened this issue May 10, 2023 · 1 comment · Fixed by #1274 or #1543
Closed

fcda-binding-list test fails #1257

Stef3st opened this issue May 10, 2023 · 1 comment · Fixed by #1274 or #1543
Assignees
@danyill
Labels
Kind: Bug Something isn't working

Comments

@Stef3st
Copy link
Contributor

Stef3st commented May 10, 2023

Describe the bug
fcda-binding-list test sometimes fails. It looks like a synchronization/timing issue.

To Reproduce
Steps to reproduce the behavior:

  1. run npm run test:watch in open-scd
  2. Check the results, it doesn't always happen which make it hard to reproduce

Expected behavior
Test will always succeed and always have the same behaviour.

Screenshots
image
@Stef3st Stef3st added the Kind: Bug Something isn't working label May 10, 2023
@Sander3003
Copy link
Member

@danyill has similar experiences

Possible solution: add an animation frame

danyill added a commit to danyill/open-scd that referenced this issue Jun 23, 2023
@danyill
fix(editors/subscription): Increase timeout for failing subscriber/fc…
0e7d0c3 
…da-binding-list test, closes openscd#1257
@danyill danyill mentioned this issue Jun 23, 2023
Merged
danyill added a commit that referenced this issue Jun 26, 2023
@danyill
fix(editors/subscription): Increase timeout for failing subscriber/fc…
8c620eb 
…da-binding-list test, closes #1257 (#1274)
@github-actions github-actions bot mentioned this issue Mar 19, 2024
Closed
@github-actions github-actions bot mentioned this issue Jun 3, 2024
Merged
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danyill danyill

Labels
Kind: Bug Something isn't working
Projects
None yet
Milestone
No milestone
3 participants
@danyill @Sander3003 @Stef3st