Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ied-editor): add tooltip with full IED name #291

Merged
merged 1 commit into from
Aug 30, 2021
Merged

fix(ied-editor): add tooltip with full IED name #291

merged 1 commit into from
Aug 30, 2021

Conversation

JakobVogelsang
Copy link
Collaborator

Closes #289

@JakobVogelsang JakobVogelsang added this to the Sprint 2021-08-13 milestone Aug 10, 2021
@JakobVogelsang JakobVogelsang self-assigned this Aug 10, 2021
ca-d
ca-d suggested changes Aug 19, 2021
View reviewed changes
Copy link
Contributor

@ca-d ca-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change should have made some tests red, at least some snapshot test.

Does this mean some tests went missing?

@JakobVogelsang
Copy link
Collaborator Author

I think the ied-editor does not have a snapshot test, yet. As this is a small thing I would suggest to add with report or smv capability.

@JakobVogelsang JakobVogelsang merged commit 3ed474a into main Aug 30, 2021
@JakobVogelsang JakobVogelsang deleted the add-tooltip-to-ied-editor branch August 30, 2021 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ca-d ca-d ca-d requested changes

@mandurisaimounika mandurisaimounika Awaiting requested review from mandurisaimounika

Assignees

@JakobVogelsang JakobVogelsang

Labels
None yet
Projects
None yet
Milestone
Sprint 2021-08-13
Development

Successfully merging this pull request may close these issues.

Usability issues of new symbols (tooltips)
2 participants
@JakobVogelsang @ca-d