Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for remote datasets #198

Draft
wants to merge 19 commits into
base: main
Choose a base branch
from
Draft

Add support for remote datasets #198

wants to merge 19 commits into from

Conversation

lewisjared
Copy link
Collaborator

@lewisjared lewisjared commented May 21, 2022

Pull request

Initial cut of a RemoteDataset class for handling API-based queries. Haven't written any docs yet, but looking for some feedback on naming/structure etc.

The added notebook contains examples of the use of the class so that might be a good place to start

Please confirm that this pull request has done the following:

  • Tests added
  • Documentation added (where applicable)
  • Example added (either to an existing notebook or as a new notebook, where applicable)
  • Description in CHANGELOG.rst added
  • Refactor database backend #195 (I'll rebase after that has been merged)
  • Better error handling

See https://github.com/openscm/scmdata/pull/198/files/b76adbb979527cc5932cbb563ff53e98439372c8..05401af873aa00871777255382b36cc33c5ef855 for a summary of the changes

@lewisjared lewisjared added the enhancement New feature or request label May 21, 2022
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@lewisjared lewisjared requested a review from znicholls May 21, 2022 12:42
@codecov
Copy link

codecov bot commented May 21, 2022

Codecov Report

Merging #198 (af605c8) into master (cc45eb2) will decrease coverage by 0.13%.
The diff coverage is 91.66%.

@@            Coverage Diff             @@
##           master     #198      +/-   ##
==========================================
- Coverage   95.79%   95.66%   -0.14%     
==========================================
  Files          23       24       +1     
  Lines        2069     2189     +120     
  Branches      388      409      +21     
==========================================
+ Hits         1982     2094     +112     
- Misses         69       77       +8     
  Partials       18       18              
Impacted Files Coverage Δ
src/scmdata/database/_database.py 100.00% <ø> (ø)
src/scmdata/remote.py 91.15% <91.15%> (ø)
src/scmdata/__init__.py 100.00% <100.00%> (ø)
src/scmdata/errors.py 90.32% <100.00%> (+2.32%) ⬆️
src/scmdata/run.py 96.17% <0.00%> (+0.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d889323...af605c8. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant