Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature/199 #255

Merged
merged 57 commits into from
Feb 17, 2018
Merged

feature/199 #255

merged 57 commits into from
Feb 17, 2018

Conversation

erikquinn
Copy link
Member

@erikquinn erikquinn commented Feb 19, 2017 •
edited by eliuuk
Loading

@jakobeng1303
Resolves #199.

Sadly I don't have a lot of time right now due to my upcoming finals. I more or less copied all the changes from the old file (which I proposed a while ago) and made compatible. Expect to have some typos or mistakes included :( To allow the player to use different transitions, the airspace has to be changed slightly (I think!)

Completion Checklist

  • terrain file
  • polygonal airspace boundary
  • all SIDs
  • all STARs
  • information to validate traffic levels
  • base video map
  • no console errors or warnings

Updates to Frankfurt (EDDF).

Original (external) PR: #198.

@erikquinn erikquinn added airport/airline/aircraft Changes to airport/airline/aircraft files WIP Add this label to work-in-progress PRs which are not yet ready for review labels Feb 19, 2017
@erikquinn erikquinn added this to the v4.2.0 milestone Feb 19, 2017
@erikquinn erikquinn added the BLOCKED Depends upon the resolution of a different issue label Feb 19, 2017
@erikquinn erikquinn mentioned this pull request Feb 19, 2017
Closed
@erikquinn
feature/199 - Remaining transitions added + additional entry points p…
eba34e2 
…er Transition

Sadly I don't have a lot of time right now due to my upcoming finals. I more or less copied all the changes from the old file (which I proposed a while ago) and made compatible. Expect to have some typos or mistakes included :( To allow the player to use different transitions, the airspace has to be changed slightly (I think!)
@erikquinn erikquinn force-pushed the feature/199 branch 2 times, most recently from 5396893 to f92e58d Compare February 20, 2017 00:59
@erikquinn
Copy link
Member Author

@jakobeng1303 @indianbhaji @Fechulo What else is needed on this airport?

@Alpi-no
Copy link
Contributor

Alpi-no commented Feb 20, 2017 •
edited
Loading

As far as I'm concerned, only an updated airspace is missing.

@erikquinn erikquinn modified the milestones: v4.4.0, v4.2.0 Apr 9, 2017
@erikquinn erikquinn removed their assignment May 1, 2017
@erikquinn
Copy link
Member Author

Work on #33 has been completed. Unblocking.

@erikquinn erikquinn removed the BLOCKED Depends upon the resolution of a different issue label May 24, 2017
@erikquinn erikquinn removed this from the v5.2.0 milestone Jul 1, 2017
@erikquinn erikquinn added the enhancement Notable improvement or expansion upon an EXISTING feature label Jul 9, 2017
@Fechulo Fechulo removed their assignment Aug 9, 2017
@eliuuk eliuuk removed their assignment Oct 3, 2017
@eliuuk
Copy link
Member

eliuuk commented Oct 3, 2017

I'll have a look at this when #108, #107 and #106 are merged

@eliuuk eliuuk self-assigned this Jan 10, 2018
@eliuuk
Copy link
Member

eliuuk commented Jan 10, 2018

Will happily take this on

@erikquinn erikquinn temporarily deployed to openscope-dev-pr-255 February 13, 2018 20:21 Inactive
@erikquinn erikquinn temporarily deployed to openscope-dev-pr-255 February 13, 2018 20:26 Inactive
@erikquinn erikquinn temporarily deployed to openscope-dev-pr-255 February 13, 2018 20:28 Inactive
Fechulo
Fechulo requested changes Feb 13, 2018
View reviewed changes
Copy link
Member

@Fechulo Fechulo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done with the SIDs. Missing ASPAT, EMPAX and PETIX arrivals. I'll continue with the STARs some other time 😩

documentation/airport-guides/eddf.md
### Sectors Available in OpenScope
```
Langen Radar (Departure)
Langen Radar (North Approach)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing one of these should be South Approach

assets/airports/eddf.json Outdated
"arrivalRunway": "25L",
"departureRunway": "25L",
"arrivalRunway": "25R",
"departureRunway": "25C",
"airspace": [
{
"floor": 0,
"ceiling": 135,
"airspace_class": "C",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Class B (US equivalent)

assets/airports/eddf.json Outdated
"rwy": {
"EDDF25L": []
},
"body": [["^DF980", "A08+|S200-"], ["VFM", "S200-"], ["DF180", "A25+"], "ROXAP", ["ADEVO", "A60"], "LISKU", "TABUM", "LIKSI", "LORPA"],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(line 898) ADEVO is shown on the chart as 6000 or above, but on the same chart, the routing says at 6000. I'd say it's actually at or above and they just forgot the + in the routing

assets/airports/eddf.json Outdated
"EDDF25L": [["^DF135", "A08+"]],
"EDDF25C": [["^DF134", "A08+"]]
},
"body": ["DONAB"],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(line 1428) Missing DF138

@erikquinn erikquinn temporarily deployed to openscope-dev-pr-255 February 14, 2018 01:01 Inactive
@erikquinn erikquinn temporarily deployed to openscope-dev-pr-255 February 14, 2018 12:52 Inactive
@Fechulo Fechulo self-requested a review February 14, 2018 22:50
Fechulo
Fechulo reviewed Feb 14, 2018
View reviewed changes
assets/airports/eddf.json Outdated
},
"body": ["DF133", ["^DF236", "A35+"], ["DF238", "A44+"], "TABUM", "TESGA"],
"exitPoints": {

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(line 1881) KERAX25N should be before KERAX25S

assets/airports/eddf.json Outdated
},
"body": ["DF133", ["^DF236", "A35+"], ["DF238", "A44+"], "TABUM", "TESGA"],
"exitPoints": {

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(line 2063) PSA25N should be before PSA25S

assets/airports/eddf.json Outdated
},
"body": ["DF133", ["^DF236", "A35+"], ["DF238", "A44+"], "TABUM", "TESGA"],
"exitPoints": {

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All arrivals are expecting 25R, would it make more sense to give some aircraft 25L instead?

assets/airports/eddf.json Outdated
},
"body": ["DF133", ["^DF236", "A35+"], ["DF238", "A44+"], "TABUM", "TESGA"],
"exitPoints": {

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove empty lines in the video map section

@erikquinn erikquinn temporarily deployed to openscope-dev-pr-255 February 16, 2018 01:44 Inactive
@erikquinn erikquinn temporarily deployed to openscope-dev-pr-255 February 16, 2018 01:48 Inactive
@eliuuk eliuuk requested a review from a team February 16, 2018 01:56
@erikquinn erikquinn temporarily deployed to openscope-dev-pr-255 February 16, 2018 01:56 Inactive
Fechulo
Fechulo requested changes Feb 16, 2018
View reviewed changes
assets/airports/airportLoadList.js Outdated
// },
{
icao: 'eddf',
level: 'medium',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

61acph is hard!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it!!!

@erikquinn erikquinn temporarily deployed to openscope-dev-pr-255 February 16, 2018 13:11 Inactive
@Fechulo Fechulo self-requested a review February 16, 2018 13:24
@erikquinn erikquinn added this to the v6.0.0 milestone Feb 17, 2018
@erikquinn erikquinn merged commit 507d315 into develop Feb 17, 2018
@erikquinn erikquinn deleted the feature/199 branch February 17, 2018 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eliuuk eliuuk eliuuk left review comments

@Fechulo Fechulo Fechulo approved these changes

Assignees

@eliuuk eliuuk

Labels
airport/airline/aircraft Changes to airport/airline/aircraft files enhancement Notable improvement or expansion upon an EXISTING feature
Projects
None yet
Milestone
v6.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@erikquinn @Alpi-no @eliuuk @Fechulo