bugfix/906 #912
bugfix/906 #912
Conversation
…nce an aircraft has left controlled airspace * updates aircraft to aircraftModel in AircraftController.update() * adds .departureExit() method to AircraftModel and consolidates .setIsRemovable() calls
|
@Fechulo be sure to clear your cache. I tested this locally with a single departure spawnPattern and it was working just fine for me. I’ll give it a shot again once I get home, but it was working. |
|
💩 But I didn’t test arrivals. Whoops. |
|
@n8rzz It doesn't work with departures either on my side, clearing the cache didn't change anything. |
|
Well shit |
| // an aircraft is exiting controlled airspace but the aircraft strip | ||
| // is still in the DOM. this where the strip gets removed from the DOM | ||
| if (!aircraftModel.inside_ctr && aircraftModel.isRemovable) { | ||
| this.removeStripView(aircraftModel); |
There was a problem hiding this comment.
Wouldn't it make more sense to remove the strip upon AircraftModel.onAirspaceExit() and AircraftController.aircraft_remove() instead of using conditional logic within the StripViewModel itself?
There was a problem hiding this comment.
The AircraftModel has no knowledge of the StripView, only the AircraftController does and .aircraft_remove() only fires once an aircraft lands or is way outside controlled airspace.
The removing logic should be consolidated and updated first before this PR does its thing.
There was a problem hiding this comment.
We could also perhaps use event bus callbacks? EVENT.EXIT_AIRSPACE and EVENT.REMOVE_AIRCRAFT or similar, which call the appropriate methods? Just spitballing anyway.
There was a problem hiding this comment.
We could do that, but we'd still have some spaghetti code. see: #916 for future work on all that
|
@n8rzz Okay to delete this branch? |
|
@erikquinn yes, I'll do that |
Resolves #906
Updates
StripViewControllerto remove a flight strip once an aircraft has left controlled airspace