Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve light theme setting menu elements to improve contrast and thus visibility + typo #188

Closed
Pentaphon opened this issue Apr 20, 2024 · 2 comments
Labels
fix-committed Fix for the issue is in the main branch

Comments

@Pentaphon
Copy link

A few tweak suggestions that I got from people I recommended TrguiNG to and I happen to agree with these. Some of these people use smaller screens and 1 person has somewhat poor eyesight so these tweaks would be very helpful to them. I also would find them helpful for my 13 inch laptop that I sometimes use. I don't have these issues on the dark theme which has noticeably better contrast than the light theme so I consider these tweaks an attempt to make both themes closer together in terms of contrast.

The main reason the dark theme has better contrast is because the light theme has checkboxes and textbox outlines that are filled in with a different shade so hopefully these tweaks to the light theme will make the light theme easier to read even though the light theme doesn't have checkboxes and textbox outlines that are filled in with a different shade. There might be a better solution but these seem to work fine considering it would be hard to fill in checkboxes and textboxes with another shade on a light theme.

The light theme's settings menu needs a few tweaks:

  1. The tab line that shows which tab is selected should be darkened to improve contrast to show which tab is being selected in light theme. If you actually zoom into the screenshot as I show below, the "selected" tab line seems to only fill in the bottom half of the main line so perhaps filling in 100% of the main line is sufficient? Or maybe it needs to be filled in 100% and darkened? See pic.

halfline

  1. The checkbox and text box outlines could be darkened to improve contrast to make them easier to see on the light theme.
  2. The update blocklist button has a typo.

Here's an image to show what I mean.

settings

qu1ck added a commit that referenced this issue Apr 20, 2024
Custom styling should only apply to server tabs and details tabs

Issue #188
@qu1ck
Copy link
Member

qu1ck commented Apr 20, 2024

  1. Fixed. It is supposed to have contrasting blue underline for active tab but I accidentally overrode it when I was customizing tabs for other components.
  2. This would be too invasive to change all outlines of all inputs of the UI lib I use. Contrast could be better but it's not bad. Maybe I'll revisit this when I migrate to mantine v7 which I plan to do in this release cycle.
  3. Fixed. Not a typo, just a label too wide for the space and your system font.

@qu1ck qu1ck added the fix-committed Fix for the issue is in the main branch label Apr 20, 2024
@qu1ck
Copy link
Member

qu1ck commented Oct 9, 2024

Fixed in v1.4.0

@qu1ck qu1ck closed this as completed Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix-committed Fix for the issue is in the main branch
Projects
None yet
Development

No branches or pull requests

2 participants