Colorful + animated progress bars

[melyux]

Re-implementation of the PR #82 from last year, on top of the recent change 05303b6. Adds the third possibility of using colorful + animated together (color based on status, animated based on activity):

Takes into account all of @qu1ck's suggestions from the original PR. Fits things to match the existing color scheme and the Transmission app:

• blue for downloading/verifying/magnetizing
• red for error
• green if seeding
• dark green if stopped @ 100%
• yellow if stopped < 100% (to match the stopped icon's color)
• gray if waiting

Only applies if user has both "colorful" and "animated" selected for progress bars in interface settings. Other combinations are unaffected by this.

[Pentaphon]

I like this! Hope to see it in the next release.

[qu1ck]

I have yet to test this fully but I noticed one thing right away: you can't just remove a config option, you have to add logic to migrate it from old style enum to your checkboxes to not lose user preferences. There are some examples of this in config class, see openTabs.

And default should be the same: animated, not colorful.

[qu1ck]

Ok, this looks good, just one more thing to address:
There is a lot of common logic of determining the progress bar variant in torrenttable.tsx and details.tsx, extract that into a single util function, you can put it in utils.js.

[melyux]

@qu1ck For the deprecated setting in the Settings interface, I'm adding it back as a string since it's stored as a string in the settings JSON. This way, we can migrate the old setting but avoid having to keep its deprecated enum. Good?

        progressbarStyle?: string, // deprecated
        animatedProgressbars: boolean,
        colorfulProgressbars: boolean,

[qu1ck]

Yes, that's fine.

[qu1ck]

Friendly ping.
I'd like to cut a release soon and include your PRs in it.

[melyux]

Sure, was on vacation and back now. Halfway done with suggestions

[melyux]

@qu1ck Check out latest changes

[qu1ck]

Fix the eslint issues please

[melyux]

Done @qu1ck

[qu1ck]

Looks good, just one question. Was it intentional that when animations are disabled then torrents will be only blue/red/green? Why disable other colors?

[melyux]

I was conservative and just kept the original state of things for the original options, while adding a new combination option. Could expand the new colors to the "colorful" option if we're feeling frisky

[qu1ck]

Well in previous implementation things were either colorful or animated, they couldn't be both. But since this change has 2 different settings for both it makes sense that the difference between [colors on, animations off] and [colors on, animations on] would be only animations, the colors would stay the same.

[qu1ck]

@melyux can you at least comment if you are going to do change discussed above?
If you don't have time I can merge this as is and amend later.

[melyux]

Since you approved it as is already I thought it was for a future release. I can make the changes now then

[qu1ck]

Please do.
Sorry for the miscommunication and being ambiguous with the approval.

[melyux]

@qu1ck Done with the changes, but since you force pushed the branch (somehow!), it won't let me push again. How can I fix it?

[qu1ck]

I just rebased your branch without changes. You can force push again.

[melyux]

@qu1ck Done

[qu1ck]

Thanks for your contribution and patience. You still have one more PR open :)