Fix macOS build #225
Merged
Fix macOS build #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qu1ck
reviewed
Sep 2, 2024
| @@ -62,6 +62,10 @@ jobs: | |||
| if: matrix.platform.rust_target == 'aarch64-apple-darwin' | |||
| run: rustup target add aarch64-apple-darwin | |||
|
|
|||
| - name: "Setup Rust" | |||
| if: matrix.platform.rust_target == 'x86_64-apple-darwin' | |||
| run: rustup target add x86_64-apple-darwin | |||
There was a problem hiding this comment.
Are you sure this does something? Isn't that the default arch?
There was a problem hiding this comment.
Sorry for the late response, must have missed a notification somehwere. But I added this because I believe the default has changed for runners. At least in this action output it says: failed to build app: Target x86_64-apple-darwin is not installed (installed targets: aarch64-apple-darwin).. So just to be sure we have build-targets available independent of which host-architecture we run on, I added the second action.
There was a problem hiding this comment.
Makes sense, rust probably changed which arch supports gets installed by default on arm macs.
Thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I encountered some issue while trying to build the macOS package locally, which worked fine before.
Changes are quite minimal, feel free to suggest changes though if you see fit.
Tested the build on my fork, you can find the output here: https://github.com/L00Cyph3r/TrguiNG/actions/runs/10668466290