Solves issue #1318 for transparent TiledImages #1319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…raw = false in the draw function.
iangilman
reviewed
Oct 5, 2017
src/tiledimage.js
Outdated
| @@ -311,6 +311,10 @@ $.extend($.TiledImage.prototype, $.EventSource.prototype, /** @lends OpenSeadrag | |||
| this._updateViewport(); | |||
| this._midDraw = false; | |||
| } | |||
| // Images with opacity 0 should not need to be drawn in future. this._needsDraw = false is set in this._updateViewport() for other images. | |||
| if (this.opacity === 0) { | |||
There was a problem hiding this comment.
Minor point, but let's just make this an else from the if statement above; feels cleaner to me.
|
Thanks, @iangilman , 'else' fixed. |
|
Awesome, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves issue #1318 . Transparent TiledImages need to set their _needsDraw to false in their draw function. _updateViewport(), which usually does this, is not called for transparent images. Otherwise, they will trigger world's draw function again and again.