Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix getTileAtPoint epsilon precision #1370

Merged
merged 1 commit into from
Apr 16, 2018

Conversation

avandecreme
Copy link
Member

Fix #1362

@iqmeta Could you test if this fix issue #1362 for you?

@iangilman
Copy link
Member

Looks good to me (just looking at the code), but hopefully we can hear from @iqmeta.

@iqmeta
Copy link

iqmeta commented Jan 8, 2018

Hi there,
okay did a grunt build of latest master. With the change of 1e-16 to 1e-15
But still double image/tile. My own hotfix is currently always have only 1 tile/image.
Maybe add an option if you know there is only one image?

image

@avandecreme
Copy link
Member Author

@iqmeta I believe you did not pick this patch when testing.

This patch has not been merged to master, so to try it you should checkout that branch.
You can do so by running this commands in your git directory:

git checkout -b avandecreme-tile_at_point master
git pull git://github.com/avandecreme/openseadragon.git tile_at_point

On the screenshot you posted, the epsilon is the one used in rectangle.js instead of tile-source.js.

I created a 2000x3033 image to test this fix and it is working for me.

@iangilman
Copy link
Member

@iqmeta Can you test again based on @avandecreme's instructions?

If not, I guess we can go ahead and merge it...

@iangilman iangilman merged commit b63c77f into openseadragon:master Apr 16, 2018
iangilman added a commit that referenced this pull request Apr 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Still second flickering image below some zoomed simple images
3 participants