preventDefaultAction in canvas-drag on minimap #1484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iangilman
reviewed
Jun 21, 2018
src/navigator.js
Outdated
| /** | ||
| * Raised when a click event occurs on the {@link OpenSeadragon.Viewer#navigator} element. | ||
| * | ||
| * @event navigator-click |
There was a problem hiding this comment.
This should be navigator-drag.
src/navigator.js
Outdated
| * @property {OpenSeadragon.Viewer} eventSource - A reference to the Viewer which raised this event. | ||
| * @property {OpenSeadragon.MouseTracker} tracker - A reference to the MouseTracker which originated this event. | ||
| * @property {OpenSeadragon.Point} position - The position of the event relative to the tracked element. | ||
| * @property {Boolean} quick - True only if the clickDistThreshold and clickTimeThreshold are both passed. Useful for differentiating between clicks and drags. |
There was a problem hiding this comment.
Looks like this is left over from the click handler. We don't need quick but it looks like we need delta, speed, and direction. You can copy their text from the viewer's canvas-drag event.
There was a problem hiding this comment.
My bad. Copy and paste without double-checking... :/
|
Locally tested: |
iangilman
added a commit
that referenced
this pull request
Jun 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To integrate #1416, 'navigator-drag' event has been added together with the preventDefaultaction support.
To block mouse drag interactions: