Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove support for IE < 11 (#1863) #1950

Merged
merged 2 commits into from
Mar 11, 2021
Merged

Remove support for IE < 11 (#1863) #1950

merged 2 commits into from
Mar 11, 2021

Conversation

rmontroy
Copy link

Remove a couple loose ends.

@msalsbery
Copy link
Member

@rmontroy Excellent, thank you!

@msalsbery msalsbery added this to the 2.5.0 milestone Mar 10, 2021
msalsbery
msalsbery approved these changes Mar 10, 2021
View reviewed changes
Copy link
Member

@msalsbery msalsbery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me! @iangilman ?

@msalsbery msalsbery linked an issue Mar 10, 2021 that may be closed by this pull request
Legacy Internet Explorer Support? #1863
Closed
@rmontroy
Copy link
Author

FYI, I installed/tested this branch in my project, and the eval use warning is gone now, which is a nice bonus.

Before:

$ npx snowpack build
[snowpack] ! building source files...
[snowpack] ✔ build complete [1.31s]
[snowpack] ! installing dependencies...
[snowpack] /Users/rob.montroy/git/virtual-slide-viewer/node_modules/openseadragon/build/openseadragon/openseadragon.js:2478:27 Use of eval is strongly discouraged, as it poses security risks and may cause issues with minification
[snowpack] ✔ install complete! [17.54s]
[snowpack] ! verifying build...
[snowpack] ✔ verification complete [0.01s]
[snowpack] ! writing build to disk...
[snowpack] ▶ Build Complete!

After:

$ npx snowpack build
[snowpack] ! building source files...
[snowpack] ✔ build complete [1.16s]
[snowpack] ! installing dependencies...
[snowpack] ✔ install complete! [16.92s]
[snowpack] ! verifying build...
[snowpack] ✔ verification complete [0.01s]
[snowpack] ! writing build to disk...
[snowpack] ▶ Build Complete!

iangilman
iangilman approved these changes Mar 10, 2021
View reviewed changes
Copy link
Member

@iangilman iangilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! We just need to add @rmontroy and this PR number to the appropriate change log item.

@msalsbery
Copy link
Member

@rmontroy One last thing: Can you please add an entry to changelog.txt?

@msalsbery msalsbery merged commit 145d742 into openseadragon:master Mar 11, 2021
@msalsbery
Copy link
Member

@rmontroy Merged, thank you again!

@iangilman
Copy link
Member

Thank you both! I went ahead and consolidated the "IE < 11" changelog entries:

d4eaefb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iangilman iangilman iangilman approved these changes

@msalsbery msalsbery msalsbery approved these changes

Assignees

@rmontroy rmontroy

Labels
None yet
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.

Legacy Internet Explorer Support?
3 participants
@rmontroy @msalsbery @iangilman