-
-
Notifications
You must be signed in to change notification settings - Fork 595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attempting to get the original target for click events #2037
Conversation
@msalsbery I've added documentation for the new property. I also went ahead and fixed the spelling of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
@@ -1191,7 +1193,7 @@ | |||
* the emulated event, a synthetic event object created with values from the actual DOM event, | |||
* or null if no DOM event applies. Emulated events can occur on eventType "wheel" on legacy mouse-scroll | |||
* event emitting user agents. | |||
* @property {Boolean} isStopable | |||
* @property {Boolean} isStoppable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice fix! ;-)
Great, thank you for the review! |
Fixes #1997
Here's my attempt to fix #1997, but it doesn't seem to be working. Here's my test code (for use in test/demo/basic.html):
When I run it and click on the overlay, the event that's logged has an
originalTarget
but it'sdiv.openseadragon-canvas
(whereas we want it to bediv.runtime-overlay
).I've tried doing
console.log
on the event duringpointerDown
handling, and those events are all in terms of the canvas. I'm not sure where to get the overlay, and why it's not showing up in the event.@msalsbery do you have any insights on this?