fix problem with click precision on ReferenceStrip #2280
Conversation
temporary fix for openseadragon#1992 . Just adding 4px which works in all use cases.
|
@damonsson Congrats! You are our 100th contributor! 😄 🎉 https://github.com/openseadragon/openseadragon/graphs/contributors |
|
Mannn, I put a lot of time into getting the hittest calculations right. Off by 4 pixels?? Inconceivable! I'm just stoked that the simplified elements/event handling I did was already merged - I thought I had it sitting on a stale branch. I do have a stale reference strip branch but it fixes using reference strip in an external element. I'll finish that! @damonsson Thank you for the fix!! 🎉 |
|
@msalsbery I'm sure those four pixels snuck in there on their own! Glad to hear you're giving the reference strip some more love; it could certainly use it! |
* master: (276 commits) Changelog for #2280 and #2238 remove trailing space fix problem with click precision on ReferenceStrip Changelog for #2273 Also add documentation for tileRetryDelay try fix with check for null and undefined fix build error Add tileRetryMax documentation. Revert async support and event breaking support in EventSource. Changelog for #2276 add box-sizing property to the navigator display region Implement support for async function and promise type recognition with $.type. Add $.Promise proxy. Implement support for promises in EventSource. Implement ability to abort events as well as prioritize events. Changelog for #2270 issues/2192 fix. Starting 4.0.1 Version 4.0.0 JSDoc fixes Changelog for #2256 Changelog for #2249 removed polling vs resizeviewer option from demo ...
Found my patch for this issue (#1992) that I spent so much time on...didn't ever get merged 🙄 |
|
@msalsbery Better late than never! 😄 ❤️ |
temporary fix for #1992 . Just adding 4px which works in all use cases.