Add setAjaxHeaders method to Viewer and TiledImage
#2346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- First draft, not tested at all - See openseadragon#1748
iangilman
requested changes
May 4, 2023
- Allow null to clear headers (same as empty object) - Add TiledImage._updateAjaxHeaders - Add error message in case of invalid headers
iangilman
reviewed
May 11, 2023
iangilman
requested changes
May 11, 2023
iangilman
requested changes
May 15, 2023
|
Unless you object, I think this PR is ready to be merged. |
iangilman
approved these changes
May 19, 2023
| @@ -115,7 +115,7 @@ $.ButtonGroup.prototype = { | |||
| /** | |||
| * Adds the given button to this button group. | |||
| * | |||
| * @functions | |||
| * @function | |||
There was a problem hiding this comment.
Thanks for fixing these, BTW!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1748 for background.
I haven't yet tested this at all.new TiledImage(...)(instead of the recommendedViewer.open(...)orViewer.addTiledImage(...)) and setajaxHeadersoptions for bothViewerandTiledImage. Previously,new TiledImage(options)didn't mergeoptions.ajaxHeaderswithViewer.ajaxHeaders, but now it does.