Support query parameters in DZI tileSource URL #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Any query parameters that are a part of the tileSource URL are added to the tile URLs.
|
Looks good! The Travis build failed, but it looks like an unrelated issue. I've restarted it; we'll see what it says. |
|
Okay, build looks good. Thanks for a lovely patch! |
iangilman
added a commit
that referenced
this pull request
Apr 14, 2014
Support query parameters in DZI tileSource URL
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a need to pass a sessionId query parameter to be able to fetch images that may require a session in order to access those images. Before this change, if the tileSource was set to:
"/path/to/image.xml?param=value"
Subsequent tile URLs would look like "/path/to/image_files/?param=value0/0_0.jpg" which is obviously invalid. This change extracts any query parameters and appends them (if there are any) onto the tile URLs.