Skip to content

Commit

Permalink
[Bug][Discover] Allow saved sort from search embeddable to load in Da…
Browse files Browse the repository at this point in the history
…shboard

Remove default sort to use saved search sort.

Issue Resolve
#5933

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
  • Loading branch information
ananzh committed Feb 23, 2024
1 parent 4ab0ca8 commit 003b797
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 7 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
- [BUG] Remove duplicate sample data as id 90943e30-9a47-11e8-b64d-95841ca0b247 ([5668](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/5668))
- [BUG][Multiple Datasource] Fix datasource testing connection unexpectedly passed with wrong endpoint [#5663](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/5663)
- [Table Visualization] Fix filter action buttons for split table aggregations ([#5619](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/5619))
- [BUG][Discover] Allow saved sort from search embeddable to load in Dashboard ([#5934](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/5934))

### 🚞 Infrastructure

Expand Down
7 changes: 0 additions & 7 deletions src/plugins/discover/public/embeddable/search_embeddable.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,6 @@ import {
} from '../../../data/public';
import { Container, Embeddable } from '../../../embeddable/public';
import { ISearchEmbeddable, SearchInput, SearchOutput } from './types';
import { getDefaultSort } from '../application/view_components/utils/get_default_sort';
import { getSortForSearchSource } from '../application/view_components/utils/get_sort_for_search_source';
import {
getRequestInspectorStats,
Expand Down Expand Up @@ -216,12 +215,6 @@ export class SearchEmbeddable
return;
}

const sort = getDefaultSort(
indexPattern,
this.services.uiSettings.get(SORT_DEFAULT_ORDER_SETTING, 'desc')
);
this.savedSearch.sort = sort;

const searchProps: SearchProps = {
columns: this.savedSearch.columns,
sort: [],
Expand Down

0 comments on commit 003b797

Please sign in to comment.