Skip to content

Commit

Permalink
[CVE] Remove storybook package to fix CVE-2021-42740 and CVE-2021-24033
Browse files Browse the repository at this point in the history
… (#2660) (#2951)

Removes the broken and unfinished storybook package and related code.

Backport PR: #1172

Signed-off-by: Zilong Xia <zilongx@amazon.com>
(cherry picked from commit 1c50eee)

Co-authored-by: ZilongX <99905560+ZilongX@users.noreply.github.com>
  • Loading branch information
joshuarrrr and ZilongX committed Nov 30, 2022
1 parent e095420 commit 3ce2731
Show file tree
Hide file tree
Showing 28 changed files with 231 additions and 4,313 deletions.
1 change: 0 additions & 1 deletion .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -388,7 +388,6 @@ module.exports = {
*/
{
files: [
'**/*.stories.tsx',
'test/*/config.ts',
'test/*/config_open.ts',
'test/*/{tests,test_suites,apis,apps}/**/*',
Expand Down
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
* [Legacy Maps Plugin] Prevent reverse-tabnabbing ([#2540](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/2540))
* [CVE-2022-0155] Bump follow-redirects to 1.15.2 [#2653](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/2653))
* [CVE-2022-0536] Bump follow-redirects to 1.15.2 [#2653](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/2653))
* [CVE-2021-24033] Remove storybook package to fix CVE-2021-42740 and CVE-2021-24033 ([#2660](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/2660))
* [CVE-2021-42740] Remove storybook package to fix CVE-2021-42740 and CVE-2021-24033 ([#2660](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/2660))

### 📈 Features/Enhancements

Expand All @@ -29,6 +31,7 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
Add the release runbook to RELEASING.md ([#2533](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/2533))

### 🛠 Maintenance
* Remove storybook package and related code ([#2660](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/2660))

### 🪛 Refactoring

Expand Down
6 changes: 3 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -67,15 +67,15 @@
"build:types": "rm -rf ./target/types && tsc --p tsconfig.types.json",
"docs:acceptApiChanges": "node --max-old-space-size=6144 scripts/check_published_api_changes.js --accept",
"osd:bootstrap": "node scripts/build_ts_refs && node scripts/register_git_hook",
"spec_to_console": "node scripts/spec_to_console",
"storybook": "node scripts/storybook"
"spec_to_console": "node scripts/spec_to_console"
},
"repository": {
"type": "git",
"url": "https://github.com/opensearch-project/opensearch-dashboards.git"
},
"resolutions": {
"**/@types/node": ">=10.17.17 <10.20.0",
"**/@types/react": "^16.14.23",
"**/ansi-regex": "^5.0.1",
"**/axios": "^0.21.4",
"**/ejs": "^3.1.6",
Expand Down Expand Up @@ -316,7 +316,7 @@
"@types/podium": "^1.0.0",
"@types/prop-types": "^15.7.3",
"@types/reach__router": "^1.2.6",
"@types/react": "^16.9.36",
"@types/react": "^16.14.23",
"@types/react-dom": "^16.9.8",
"@types/react-grid-layout": "^0.16.7",
"@types/react-redux": "^7.1.9",
Expand Down
41 changes: 0 additions & 41 deletions packages/osd-storybook/README.md

This file was deleted.

34 changes: 0 additions & 34 deletions packages/osd-storybook/index.ts

This file was deleted.

37 changes: 0 additions & 37 deletions packages/osd-storybook/lib/constants.ts

This file was deleted.

41 changes: 0 additions & 41 deletions packages/osd-storybook/lib/default_config.ts

This file was deleted.

49 changes: 0 additions & 49 deletions packages/osd-storybook/lib/register.ts

This file was deleted.

88 changes: 0 additions & 88 deletions packages/osd-storybook/lib/run_storybook_cli.ts

This file was deleted.

Loading

0 comments on commit 3ce2731

Please sign in to comment.