update

Signed-off-by: tygao <tygao@amazon.com>
opensearch-project · Aug 14, 2024 · 52a3e1d · 52a3e1d
1 parent 2c770f4
commit 52a3e1d
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 7 deletions.
diff --git a/src/plugins/workspace/public/components/workspace_detail_app.tsx b/src/plugins/workspace/public/components/workspace_detail_app.tsx
@@ -36,9 +36,12 @@ export const WorkspaceDetailApp = (props: WorkspaceDetailProps) => {
         text: currentWorkspace.name,
       });
       breadcrumbs.push({
-        text: `${currentWorkspace.name} ${i18n.translate('workspace.detail.title', {
-          defaultMessage: 'settings',
-        })}`,
+        text: i18n.translate('workspace.detail.title', {
+          defaultMessage: '{name} settings',
+          values: {
+            name: currentWorkspace.name,
+          },
+        }),
       });
     }
     chrome?.setBreadcrumbs(breadcrumbs);

diff --git a/src/plugins/workspace/public/components/workspace_list/index.tsx b/src/plugins/workspace/public/components/workspace_list/index.tsx
@@ -82,7 +82,7 @@ export const WorkspaceList = ({ registeredUseCases$ }: WorkspaceListProps) => {
   }, [workspaceList, queryInput]);
 
   const workspaceCreateUrl = useMemo(() => {
-    if (!application || !http) {
+    if (!application) {
       return '';
     }
 
@@ -92,10 +92,9 @@ export const WorkspaceList = ({ registeredUseCases$ }: WorkspaceListProps) => {
     if (!appUrl) return '';
 
     return cleanWorkspaceId(appUrl);
-  }, [application, http]);
+  }, [application]);
 
   const renderCreateWorkspaceButton = () => {
-    if (!isDashboardAdmin) return null;
     const button = (
       <EuiSmallButton
         href={workspaceCreateUrl}
@@ -210,7 +209,7 @@ export const WorkspaceList = ({ registeredUseCases$ }: WorkspaceListProps) => {
         ]}
         setMountPoint={application?.setAppDescriptionControls}
       />
-      {renderCreateWorkspaceButton()}
+      {isDashboardAdmin && renderCreateWorkspaceButton()}
       <EuiPageBody panelled>
         <EuiPageContent
           verticalPosition="center"