removed unused code

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
opensearch-project · May 17, 2023 · 6d9b9b4 · 6d9b9b4
1 parent 67cc5f5
commit 6d9b9b4
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/src/plugins/ui_actions/public/index.ts b/src/plugins/ui_actions/public/index.ts
@@ -70,7 +70,6 @@ export {
   ActionContextMapping,
   ActionType,
   VisualizeFieldContext,
-  ExternalActionContext,
   ACTION_VISUALIZE_FIELD,
   ACTION_VISUALIZE_GEO_FIELD,
   ACTION_VISUALIZE_LENS_FIELD,

diff --git a/src/plugins/vis_type_vega/public/data_model/vega_parser.ts b/src/plugins/vis_type_vega/public/data_model/vega_parser.ts
@@ -332,6 +332,8 @@ The URL is an identifier only. OpenSearch Dashboards and your browser will never
         if (mark) {
           signals.forEach((signal: Signal) => {
             signal.on?.forEach((eventObj) => {
+              // We are prepending mark name here so that the signals only listens to the events on
+              // the elements related to this mark
               eventObj.events = `@${mark.name}:${eventObj.events}`;
             });
           });
@@ -342,7 +344,8 @@ The URL is an identifier only. OpenSearch Dashboards and your browser will never
   }
 
   /**
-   *
+   * This method recursively looks for a mark that includes the given style.
+   * Returns undefined if it doesn't find it.
    */
   getMarkWithStyle(marks: any[], style: string): any {
     if (!marks) {