Skip to content

Commit

Permalink
address minor comments
Browse files Browse the repository at this point in the history
Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>
  • Loading branch information
lezzago committed Jun 19, 2023
1 parent 95c957b commit cca64a9
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion src/plugins/vis_augmenter/public/utils/utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ export const isEligibleForVisLayers = (vis: Vis, uiSettingsClient?: IUiSettingsC
vis.params?.type === 'line';

// Checks if the augmentation setting is enabled
const config = uiSettingsClient !== undefined ? uiSettingsClient : getUISettings();
const config = uiSettingsClient ?? getUISettings();
const isAugmentationEnabled = config.get(PLUGIN_AUGMENTATION_ENABLE_SETTING);
return isAugmentationEnabled && hasValidXaxis && hasCorrectAggregationCount && hasOnlyLineSeries;
};
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ export async function fetchVisEmbeddable(
savedObjectId: string,
embeddableStart?: EmbeddableStart
): Promise<VisualizeEmbeddable> {
const embeddableLoader = embeddableStart !== undefined ? embeddableStart : getEmbeddable();
const embeddableLoader = embeddableStart ?? getEmbeddable();
const embeddableVisFactory = embeddableLoader.getEmbeddableFactory('visualization');
const contextInput = {
filters: getQueryService().filterManager.getFilters(),
Expand Down

0 comments on commit cca64a9

Please sign in to comment.