Upgrades webpack-dev-server and webpack-cli (#1229)

* Upgrades `webpack-cli` from v3.3.10 to v4.9.2 * [CHANGELOG](https://github.com/webpack/webpack-cli/blob/webpack-cli%404.9.2/CHANGELOG.md) * `webpack-cli` changed the way that the `--env` flag is parsed. See webpack/webpack-cli#1216 for more information. * Upgrades `webpack-dev-server` from v3.11.2 to v4.7.4 * [CHANGELOG](https://github.com/webpack/webpack-dev-server/blob/v4.7.4/CHANGELOG.md) * [Migration guide](https://github.com/webpack/webpack-dev-server/blob/master/migration-v4.md) Resolves #1065 Signed-off-by: Tommy Markley <markleyt@amazon.com>
opensearch-project · Feb 11, 2022 · f981b39 · f981b39
1 parent b8a2270
commit f981b39
Show file tree

Hide file tree

Showing 6 changed files with 462 additions and 337 deletions.
diff --git a/packages/osd-interpreter/package.json b/packages/osd-interpreter/package.json
@@ -32,6 +32,6 @@
     "supports-color": "^7.0.0",
     "url-loader": "^2.2.0",
     "webpack": "^4.41.5",
-    "webpack-cli": "^3.3.10"
+    "webpack-cli": "^4.9.2"
   }
 }
diff --git a/packages/osd-monaco/package.json b/packages/osd-monaco/package.json
@@ -22,6 +22,6 @@
     "supports-color": "^7.0.0",
     "typescript": "4.0.2",
     "webpack": "^4.41.5",
-    "webpack-cli": "^3.3.10"
+    "webpack-cli": "^4.9.2"
   }
 }
diff --git a/packages/osd-monaco/scripts/build.js b/packages/osd-monaco/scripts/build.js
@@ -46,14 +46,14 @@ run(
     await del(TARGET_BUILD_DIR);
 
     const cwd = ROOT_DIR;
-    const env = { ...process.env };
+    const env = { ...process.env, dev: !!flags.dev, prod: !flags.dev };
     if (supportsColor.stdout) {
       env.FORCE_COLOR = 'true';
     }
 
     await procRunner.run('worker', {
       cmd: 'webpack',
-      args: ['--config', WEBPACK_CONFIG_PATH, flags.dev ? '--env.dev' : '--env.prod'],
+      args: ['--config', WEBPACK_CONFIG_PATH],
       wait: true,
       env,
       cwd,

diff --git a/packages/osd-pm/package.json b/packages/osd-pm/package.json
@@ -65,7 +65,7 @@
     "typescript": "4.0.2",
     "unlazy-loader": "^0.1.3",
     "webpack": "^4.41.5",
-    "webpack-cli": "^3.3.10",
+    "webpack-cli": "^4.9.2",
     "write-pkg": "^4.0.0"
   },
   "dependencies": {

diff --git a/packages/osd-ui-framework/package.json b/packages/osd-ui-framework/package.json
@@ -57,6 +57,6 @@
     "sinon": "^7.4.2",
     "style-loader": "^1.1.3",
     "webpack": "^4.41.5",
-    "webpack-dev-server": "^3.11.2"
+    "webpack-dev-server": "^4.7.4"
   }
 }