-
Notifications
You must be signed in to change notification settings - Fork 909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[nodejs client] hookup issues in src/core/server/saved_objects #1216
Comments
ananzh
added a commit
to ananzh/OpenSearch-Dashboards
that referenced
this issue
Feb 7, 2022
1.import Client from '@opensearch-project/opensearch/api/new' to hook up the new types 2.add support functions. for example, add a support function for converting a possibly not existant doc to an existant doc. 3.add @ts-expect-error to expected mismatches 4.fix undefined and mismatched types 5.fix unit tests in src/core/server/saved_objects Issue Resolved: opensearch-project#1216 Partical Resolved: opensearch-project/opensearch-js#837 Signed-off-by: Anan Zhuang <ananzh@amazon.com>
ananzh
added a commit
to ananzh/OpenSearch-Dashboards
that referenced
this issue
Feb 7, 2022
1.import Client from '@opensearch-project/opensearch/api/new' to hook up the new types 2.add support functions. for example, add a support function for converting a possibly not existant doc to an existant doc. 3.add @ts-expect-error to expected mismatches 4.fix undefined and mismatched types 5.fix unit tests in src/core/server/saved_objects Issue Resolved: opensearch-project#1216 Partical Resolved: opensearch-project/opensearch-js#837 Signed-off-by: Anan Zhuang <ananzh@amazon.com>
This was referenced Feb 7, 2022
ananzh
added a commit
to ananzh/OpenSearch-Dashboards
that referenced
this issue
Feb 7, 2022
1.import Client from '@opensearch-project/opensearch/api/new' to hook up the new types 2.add support functions. for example, add a support function for converting a possibly not existant doc to an existant doc. 3.add @ts-expect-error to expected mismatches 4.fix undefined and mismatched types 5.fix unit tests in src/core/server/saved_objects Issue Resolved: opensearch-project#1216 Partical Resolved: opensearch-project#837 Signed-off-by: Anan Zhuang <ananzh@amazon.com>
ananzh
added a commit
to ananzh/OpenSearch-Dashboards
that referenced
this issue
Feb 8, 2022
1.import Client from '@opensearch-project/opensearch/api/new' to hook up the new types 2.add support functions. for example, add a support function for converting a possibly not existant doc to an existant doc. 3.add @ts-expect-error to expected mismatches 4.fix undefined and mismatched types 5.fix unit tests in src/core/server/saved_objects Issue Resolved: opensearch-project#1216 Partical Resolved: opensearch-project#837 Signed-off-by: Anan Zhuang <ananzh@amazon.com>
ananzh
added a commit
to ananzh/OpenSearch-Dashboards
that referenced
this issue
Feb 8, 2022
1.import Client from '@opensearch-project/opensearch/api/new' to hook up the new types 2.add support functions. for example, add a support function for converting a possibly not existant doc to an existant doc. 3.add @ts-expect-error to expected mismatches 4.fix undefined and mismatched types 5.fix unit tests in src/core/server/saved_objects Issue Resolved: opensearch-project#1216 Partical Resolved: opensearch-project#837 Signed-off-by: Anan Zhuang <ananzh@amazon.com>
ananzh
added a commit
to ananzh/OpenSearch-Dashboards
that referenced
this issue
Feb 17, 2022
1.import Client from '@opensearch-project/opensearch/api/new' to hook up the new types 2.add support functions. for example, add a support function for converting a possibly not existant doc to an existant doc. 3.add @ts-expect-error to expected mismatches 4.fix undefined and mismatched types 5.fix unit tests in src/core/server/saved_objects Fix comments and modify import types Issue Resolved: opensearch-project#1216 Partical Resolved: opensearch-project#837 Signed-off-by: Anan Zhuang <ananzh@amazon.com>
ananzh
added a commit
to ananzh/OpenSearch-Dashboards
that referenced
this issue
Feb 23, 2022
1.import Client from '@opensearch-project/opensearch/api/new' to hook up the new types 2.add support functions. for example, add a support function for converting a possibly not existant doc to an existant doc. 3.add @ts-expect-error to expected mismatches 4.fix undefined and mismatched types 5.fix unit tests in src/core/server/saved_objects Issue Resolved: opensearch-project#1216 Partical Resolved: opensearch-project/opensearch-js#837 Signed-off-by: Anan Zhuang <ananzh@amazon.com>
ananzh
added a commit
to ananzh/OpenSearch-Dashboards
that referenced
this issue
Feb 25, 2022
1.import Client from '@opensearch-project/opensearch/api/new' to hook up the new types 2.add support functions. for example, add a support function for converting a possibly not existant doc to an existant doc. 3.add @ts-expect-error to expected mismatches 4.fix undefined and mismatched types 5.fix unit tests in src/core/server/saved_objects Fix comments and modify import types Remove require_alias Issue Resolved: opensearch-project#1216 Partical Resolved: opensearch-project#837 Signed-off-by: Anan Zhuang <ananzh@amazon.com> modify repository Signed-off-by: Anan Zhuang <ananzh@amazon.com>
ananzh
added a commit
to ananzh/OpenSearch-Dashboards
that referenced
this issue
Feb 28, 2022
1.import Client from '@opensearch-project/opensearch/api/new' to hook up the new types 2.add support functions. for example, add a support function for converting a possibly not existant doc to an existant doc. 3.add @ts-expect-error to expected mismatches 4.fix undefined and mismatched types 5.fix unit tests in src/core/server/saved_objects Issue Resolved: opensearch-project#1216 Partical Resolved: opensearch-project/opensearch-js#837 Signed-off-by: Anan Zhuang <ananzh@amazon.com>
ananzh
added a commit
to ananzh/OpenSearch-Dashboards
that referenced
this issue
Mar 2, 2022
1.import Client from '@opensearch-project/opensearch/api/new' to hook up the new types 2.add support functions. for example, add a support function for converting a possibly not existant doc to an existant doc. 3.add @ts-expect-error to expected mismatches 4.fix undefined and mismatched types 5.fix unit tests in src/core/server/saved_objects Fix comments and modify import types Remove require_alias remove coreMigrationVersion to avoid bwc issue Issue Resolved: opensearch-project#1216 Partical Resolved: opensearch-project#837 Signed-off-by: Anan Zhuang <ananzh@amazon.com> modify repository Signed-off-by: Anan Zhuang <ananzh@amazon.com>
ananzh
added a commit
to ananzh/OpenSearch-Dashboards
that referenced
this issue
Mar 4, 2022
1.import Client from '@opensearch-project/opensearch/api/new' to hook up the new types 2.add support functions. for example, add a support function for converting a possibly not existant doc to an existant doc. 3.add @ts-expect-error to expected mismatches 4.fix undefined and mismatched types 5.fix unit tests in src/core/server/saved_objects Fix comments and modify import types Remove require_alias remove coreMigrationVersion to avoid bwc issue modify repository add param comments Issue Resolved: opensearch-project#1216 Partical Resolved: opensearch-project#837 Signed-off-by: Anan Zhuang <ananzh@amazon.com>
ananzh
added a commit
that referenced
this issue
Mar 4, 2022
…1223) 1.import Client from '@opensearch-project/opensearch/api/new' to hook up the new types 2.add support functions. for example, add a support function for converting a possibly not existant doc to an existant doc. 3.add @ts-expect-error to expected mismatches 4.fix undefined and mismatched types 5.fix unit tests in src/core/server/saved_objects Fix comments and modify import types Remove require_alias remove coreMigrationVersion to avoid bwc issue modify repository add param comments Issue Resolved: #1216 Partical Resolved: #837 Signed-off-by: Anan Zhuang <ananzh@amazon.com>
ananzh
added a commit
that referenced
this issue
Mar 5, 2022
…1223) 1.import Client from '@opensearch-project/opensearch/api/new' to hook up the new types 2.add support functions. for example, add a support function for converting a possibly not existant doc to an existant doc. 3.add @ts-expect-error to expected mismatches 4.fix undefined and mismatched types 5.fix unit tests in src/core/server/saved_objects Fix comments and modify import types Remove require_alias remove coreMigrationVersion to avoid bwc issue modify repository add param comments Issue Resolved: #1216 Partical Resolved: #837 Signed-off-by: Anan Zhuang <ananzh@amazon.com>
ananzh
added a commit
that referenced
this issue
Mar 5, 2022
…1223) 1.import Client from '@opensearch-project/opensearch/api/new' to hook up the new types 2.add support functions. for example, add a support function for converting a possibly not existant doc to an existant doc. 3.add @ts-expect-error to expected mismatches 4.fix undefined and mismatched types 5.fix unit tests in src/core/server/saved_objects Fix comments and modify import types Remove require_alias remove coreMigrationVersion to avoid bwc issue modify repository add param comments Issue Resolved: #1216 Partical Resolved: #837 Signed-off-by: Anan Zhuang <ananzh@amazon.com>
ananzh
added a commit
to ananzh/OpenSearch-Dashboards
that referenced
this issue
Mar 12, 2022
1.change @elastic/elasticsearch to @opensearch-project/opensearch 2.add path in tsconfig.base.json to let nodejs types point to api/new.d.ts which is the new defined types 3.fix hookup issues in src/core/server/opensearch 4.fix hookup issues in src/core/server/core_usage_data_service.ts 5.fix hookup issues in src/core/server/saved_objects Issue Resolved: opensearch-project#1193 Issue Resolved: opensearch-project#1224 Issue Resolved: opensearch-project#1216 Partical Resolved: opensearch-project#837 Signed-off-by: Anan Zhuang <ananzh@amazon.com>
7 tasks
ananzh
added a commit
to ananzh/OpenSearch-Dashboards
that referenced
this issue
Mar 12, 2022
1.change @elastic/elasticsearch to @opensearch-project/opensearch 2.add path in tsconfig.base.json to let nodejs types point to api/new.d.ts which is the new defined types 3.fix hookup issues in src/core/server/opensearch 4.fix hookup issues in src/core/server/core_usage_data_service.ts 5.fix hookup issues in src/core/server/saved_objects Sub-Issue Resolved: opensearch-project#1193 Sub-Issue Resolved: opensearch-project#1224 Sub-Issue Resolved: opensearch-project#1216 Issue Resolved: opensearch-project#837 Signed-off-by: Anan Zhuang <ananzh@amazon.com>
ananzh
added a commit
to ananzh/OpenSearch-Dashboards
that referenced
this issue
Mar 18, 2022
1.change @elastic/elasticsearch to @opensearch-project/opensearch 2.add path in tsconfig.base.json to let nodejs types point to api/new.d.ts which is the new defined types 3.fix hookup issues in src/core/server/opensearch 4.fix hookup issues in src/core/server/core_usage_data_service.ts 5.fix hookup issues in src/core/server/saved_objects fix PR comments and add more explains to type mismatch Sub-Issue Resolved: opensearch-project#1193 Sub-Issue Resolved: opensearch-project#1224 Sub-Issue Resolved: opensearch-project#1216 Issue Resolved: opensearch-project#837 Signed-off-by: Anan Zhuang <ananzh@amazon.com>
ananzh
added a commit
to ananzh/OpenSearch-Dashboards
that referenced
this issue
Mar 18, 2022
1.change @elastic/elasticsearch to @opensearch-project/opensearch 2.add path in tsconfig.base.json to let nodejs types point to api/new.d.ts which is the new defined types 3.fix hookup issues in src/core/server/opensearch 4.fix hookup issues in src/core/server/core_usage_data_service.ts 5.fix hookup issues in src/core/server/saved_objects fix PR comments and add more explains to type mismatch Sub-Issue Resolved: opensearch-project#1193 Sub-Issue Resolved: opensearch-project#1224 Sub-Issue Resolved: opensearch-project#1216 Issue Resolved: opensearch-project#837 Signed-off-by: Anan Zhuang <ananzh@amazon.com>
kavilla
pushed a commit
that referenced
this issue
Mar 23, 2022
1.change @elastic/elasticsearch to @opensearch-project/opensearch 2.add path in tsconfig.base.json to let nodejs types point to api/new.d.ts which is the new defined types 3.fix hookup issues in src/core/server/opensearch 4.fix hookup issues in src/core/server/core_usage_data_service.ts 5.fix hookup issues in src/core/server/saved_objects fix PR comments and add more explains to type mismatch Sub-Issue Resolved: #1193 Sub-Issue Resolved: #1224 Sub-Issue Resolved: #1216 Issue Resolved: #837 Signed-off-by: Anan Zhuang <ananzh@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
opensearch saved_objects api has issues after nodejs client hooked up with dashboards. Some major issues are:
import { Client } from '@opensearch-project/opensearch'
is not pointing to the correct typestypes mismatch. for example,
ShardsInfo
needs to be replaced withShardStatistics
. This is due to api changes. Use scroll api as an example:Here
ScrollResponse
exports interfaceSearchResponse
which needs_shards: ShardStatistics
. Here is a sample issue for types mismatch:To Reproduce
Expected behavior
clean out all issue in
src/core/server/saved_objects
OpenSearch Version
2.0
Dashboards Version
2.0
All Issues in src/core/server/saved_objects
The text was updated successfully, but these errors were encountered: