Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DeAngular][visualization][vislib] clean angular code in vis_type_vislib #2137

Closed
ananzh opened this issue Aug 12, 2022 · 0 comments · Fixed by #2138
Closed

[DeAngular][visualization][vislib] clean angular code in vis_type_vislib #2137

ananzh opened this issue Aug 12, 2022 · 0 comments · Fixed by #2138
Assignees
@ananzh
Labels
de-angular de-angularize work technical debt If not paid, jeapardizes long-term success and maintainability of the repository. visualizations Issues and PRs related to visualizations

Comments

@ananzh
Copy link
Member

ananzh commented Aug 12, 2022

vis_type_vislib only has one file contains angular import and angular $scope.

From upstream, there are two places using Binder

  1. In Tooltip, create a new Binder class this.binder = new Binder() (code reference)

  2. In Handler, create a new Binder class this.binder = new Binder() (code reference)

There is no place to use angular $scope in the vis_type_vislib. Therefore, we could do an easy removing.

This issue is part of #1560 .
@ananzh ananzh added visualizations Issues and PRs related to visualizations de-angular de-angularize work labels Aug 12, 2022
@ananzh ananzh mentioned this issue Aug 12, 2022
Closed
ananzh added a commit to ananzh/OpenSearch-Dashboards that referenced this issue Aug 12, 2022
@ananzh
[DeAngular][visualization][vislib] remove angular from vislib
88dd5c1 
* remove angular import and $scope from Binder class since there is
no usage in the code

Issue resolved:
opensearch-project#2137

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
ananzh added a commit to ananzh/OpenSearch-Dashboards that referenced this issue Aug 12, 2022
@ananzh
[DeAngular][visualization][vislib] remove angular from vislib
fa4023f 
* remove angular import and $scope from Binder class since there is
no usage in the code

Issue resolved:
opensearch-project#2137

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
@ananzh ananzh mentioned this issue Aug 12, 2022
Merged
7 tasks
@ananzh ananzh self-assigned this Aug 12, 2022
@ananzh ananzh added the technical debt If not paid, jeapardizes long-term success and maintainability of the repository. label Aug 12, 2022
@kavilla kavilla linked a pull request Aug 15, 2022 that will close this issue
[DeAngular][visualization][vislib] remove angular from vislib #2138
Merged
7 tasks
ananzh added a commit to ananzh/OpenSearch-Dashboards that referenced this issue Aug 15, 2022
@ananzh
[DeAngular][visualization][vislib] remove angular from vislib
e5060c9 
* remove angular import and $scope from Binder class since there is
no usage in the code

Issue resolved:
opensearch-project#2137

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
ananzh added a commit that referenced this issue Aug 25, 2022
@ananzh
[DeAngular][visualization][vislib] remove angular from vislib (#2138)
730a75a 
* remove angular import and $scope from Binder class since there is
no usage in the code

Issue resolved:
#2137

Signed-off-by: Anan Zhuang <ananzh@amazon.com>

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
opensearch-trigger-bot bot pushed a commit that referenced this issue Sep 6, 2022
@ananzh @github-actions
[DeAngular][visualization][vislib] remove angular from vislib (#2138)
5533c13 
* remove angular import and $scope from Binder class since there is
no usage in the code

Issue resolved:
#2137

Signed-off-by: Anan Zhuang <ananzh@amazon.com>

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
(cherry picked from commit 730a75a)
joshuarrrr pushed a commit that referenced this issue Sep 6, 2022
@opensearch-trigger-bot @ananzh
[DeAngular][visualization][vislib] remove angular from vislib (#2138) (…
b6ab762 
…#2270)

* remove angular import and $scope from Binder class since there is
no usage in the code

Issue resolved:
#2137

Signed-off-by: Anan Zhuang <ananzh@amazon.com>

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
(cherry picked from commit 730a75a)

Co-authored-by: Anan Zhuang <ananzh@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ananzh ananzh

Labels
de-angular de-angularize work technical debt If not paid, jeapardizes long-term success and maintainability of the repository. visualizations Issues and PRs related to visualizations
Projects
Dashboards DeAngularization
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[DeAngular][visualization][vislib] remove angular from vislib ananzh/OpenSearch-Dashboards
1 participant
@ananzh