Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Meta] Plugin Decoupling #287

Open
4 tasks
mihirsoni opened this issue Apr 14, 2021 · 7 comments
Open
4 tasks

[Meta] Plugin Decoupling #287

mihirsoni opened this issue Apr 14, 2021 · 7 comments
Assignees
@AMoo-Miki
Labels
discuss enhancement New feature or request plugins Plugin related work proposal

Comments

@mihirsoni
Copy link
Contributor

mihirsoni commented Apr 14, 2021 •
edited by tmarkley
Loading

Is your feature request related to a problem? Please describe.
Currently, developing plugin is cumbersome, requires entire repository to be available. We should find a way to reduce this and make Dashboards plugin development simplified.

Specific problems include

  • coupled versioning/build
  • coupled dependencies
  • lack of a true extensibility platform for customers (e.g. dynamic loading of extensions)
  • and more (WIP)

Describe the solution you'd like
Publish all independent packages to NPM repository (plugin-helpers/ generators) and provide docker based plugin development to get it started
@mihirsoni mihirsoni added enhancement New feature or request discuss labels Apr 14, 2021
@mihirsoni mihirsoni changed the title [Discuss] [Core] Decouple Plugin development Proposal: [Discuss] [Core] Decouple Plugin development Apr 15, 2021
@tmarkley
Copy link
Contributor

This is a great idea. We need to put together a plan to address this.

@dblock
Copy link
Member

dblock commented Jul 21, 2021

@saratvemulapalli

@ahopp
Copy link
Contributor

ahopp commented Mar 3, 2022

@saratvemulapalli What are we thinking on this?

@saratvemulapalli
Copy link
Member

saratvemulapalli commented Mar 3, 2022 •
edited
Loading

@ahopp the foundations to make this happen is in progress for OpenSearch.
We are building a SDK to build extensions for OpenSearch.
We could start exploring similar idea's for Dashboards.

@ahopp
Copy link
Contributor

ahopp commented Mar 3, 2022

@saratvemulapalli thanks, that's super helpful! I'll take a look at the meta issue and the work you've been doing.

@tmarkley tmarkley changed the title Proposal: [Discuss] [Core] Decouple Plugin development Proposal: Decouple Plugin development May 25, 2022
@tmarkley tmarkley changed the title Proposal: Decouple Plugin development Proposal: Decouple Plugin development and versioning May 25, 2022
@tmarkley tmarkley added the plugins Plugin related work label May 25, 2022
@tmarkley tmarkley changed the title Proposal: Decouple Plugin development and versioning [Meta] Decouple Plugin development May 25, 2022
@tmarkley
Copy link
Contributor

I'm going to utilize this issue for the research and planning of plugin decoupling.

@tmarkley tmarkley mentioned this issue May 25, 2022
Closed
@tmarkley tmarkley changed the title [Meta] Decouple Plugin development [Meta] Plugin Decoupling May 25, 2022
@tmarkley tmarkley removed their assignment Jun 20, 2022
@ashwin-pc ashwin-pc mentioned this issue Jun 21, 2022
Closed
@dblock dblock mentioned this issue Oct 18, 2022
Open
@seanneumann seanneumann assigned AMoo-Miki and unassigned kavilla Nov 7, 2022
@joshuarrrr joshuarrrr mentioned this issue Nov 15, 2022
Open
@wbeckler
Copy link

wbeckler commented Jul 6, 2023

@mihirsoni What did you mean by "docker based plugin development"?

Hailong-am pushed a commit to Hailong-am/OpenSearch-Dashboards that referenced this issue Mar 8, 2024
@gaobinlong @joshuarrrr @SuZhou-Joe
[Workspace][Feature] Add ACL related functions (opensearch-project#5084…
e4ce3e0 
…) (opensearch-project#287)

* [Workspace] Add ACL related functions for workspace (opensearch-project#146)

* [Workspace] Add acl related functions for workspace



* Minor change



---------



* Modify changelog



* Add more unit test cases



* Modify test case



* Some minor change



* Add more test cases



* Optimize some code and the comments of the functions



* Add more comments for some basic functions



* Export more interfaces



* consume permissions in repository



* feat: consume permissions in serializer



* Add unit tests for consuming permissions in repository



* Remove double exclamation



* Rename some variables



* Remove duplicated semicolon



* Add permissions field to the mapping only if the permission control is enabled



* Fix test failure



* Add feature flag config to the yml file



* Make the comment of feature flag more clear



* Make comment more clear



* Remove management permission type



* Fix test failure



---------

Signed-off-by: gaobinlong <gbinlong@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Co-authored-by: Josh Romero <rmerqg@amazon.com>
Co-authored-by: SuZhou-Joe <suzhou@amazon.com>
SuZhou-Joe added a commit to SuZhou-Joe/OpenSearch-Dashboards that referenced this issue Mar 18, 2024
@gaobinlong @joshuarrrr @SuZhou-Joe
[Workspace][Feature] Add ACL related functions (opensearch-project#5084…
3cf8b8e 
…) (opensearch-project#287)

* [Workspace] Add ACL related functions for workspace (opensearch-project#146)

* [Workspace] Add acl related functions for workspace



* Minor change



---------



* Modify changelog



* Add more unit test cases



* Modify test case



* Some minor change



* Add more test cases



* Optimize some code and the comments of the functions



* Add more comments for some basic functions



* Export more interfaces



* consume permissions in repository



* feat: consume permissions in serializer



* Add unit tests for consuming permissions in repository



* Remove double exclamation



* Rename some variables



* Remove duplicated semicolon



* Add permissions field to the mapping only if the permission control is enabled



* Fix test failure



* Add feature flag config to the yml file



* Make the comment of feature flag more clear



* Make comment more clear



* Remove management permission type



* Fix test failure



---------

Signed-off-by: gaobinlong <gbinlong@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Co-authored-by: Josh Romero <rmerqg@amazon.com>
Co-authored-by: SuZhou-Joe <suzhou@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AMoo-Miki AMoo-Miki

Labels
discuss enhancement New feature or request plugins Plugin related work proposal
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@dblock @mihirsoni @AMoo-Miki @wbeckler @tmarkley @ahopp @kavilla @saratvemulapalli