Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] "Upload a file" button disabled in Stack Management > Index Patterns #384

Closed
kavilla opened this issue May 27, 2021 · 0 comments · Fixed by #391
Closed

[BUG] "Upload a file" button disabled in Stack Management > Index Patterns #384

kavilla opened this issue May 27, 2021 · 0 comments · Fixed by #391
Labels
bug Something isn't working

Comments

@kavilla
Copy link
Member

kavilla commented May 27, 2021

Describe the bug

When you cluster is empty and when you go to Index Patterns in Stack Management, the Upload a file button is disabled with the hover message being "This feature requires a Basic license." Once you add sample data or have any data in your cluster then this view isn't available.

Screen Shot 2021-05-27 at 11 10 53 AM

To Reproduce
Steps to reproduce the behavior:

  1. Have an empty cluster
  2. Start OpenSearch Dashboards
  3. Navigate to Index Patterns in Stack Management
  4. See disabled button

Expected behavior
So what's happening is that it's checking https://github.com/opensearch-project/OpenSearch-Dashboards/blob/main/src/plugins/index_pattern_management/public/components/index_pattern_table/empty_state/empty_state.tsx#L91 to see if it should be disabled.

The Machine Learning plugin was removed as it is under x-pack and this button routes users to the file visualization under that plugin (e.g., http://localhost:5603/ahk/app/ml#/filedatavisualizer). So it's disable to prevent users from getting 404. However, there still ways to upload files for example going to Stack Management > Saved Objects > Import, but doesn't provide the GUI as before. So it's a little confusing because it implies an upsell when there is none and it really is just disabled because the file visualization doesn't exist anymore.

An immediate fix would be to delete this button but should there be a replacement?

OpenSearch Version
1.0

Dashboards Version
1.0

Plugins

Please list all plugins currently enabled.

Screenshots

If applicable, add screenshots to help explain your problem.

Host/Environment (please complete the following information):

  • OS: Mac OS
  • Browser and version: Firefox

Additional context

Add any other context about the problem here.

@kavilla kavilla added bug Something isn't working Beta untriaged and removed untriaged labels May 27, 2021
kavilla added a commit to kavilla/OpenSearch-Dashboards-1 that referenced this issue May 30, 2021
Left-over upsells and branding that were missed in previous
updates since they are not easy to catch.

Issues:
opensearch-project#388
opensearch-project#384

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
@kavilla kavilla linked a pull request May 30, 2021 that will close this issue
5 tasks
kavilla added a commit to kavilla/OpenSearch-Dashboards-1 that referenced this issue Jun 2, 2021
Left-over upsells and branding that were missed in previous
updates since they are not easy to catch.

Issues:
opensearch-project#359
opensearch-project#388
opensearch-project#384

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
kavilla added a commit that referenced this issue Jun 3, 2021
Left-over upsells and branding that were missed in previous
updates since they are not easy to catch.

Issues:
#359
#388
#384

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
kavilla added a commit that referenced this issue Jun 3, 2021
Left-over upsells and branding that were missed in previous
updates since they are not easy to catch.

Issues:
#359
#388
#384

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
kavilla added a commit that referenced this issue Jun 3, 2021
Left-over upsells and branding that were missed in previous
updates since they are not easy to catch.

Issues:
#359
#388
#384

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant