Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Play/Wrench Button Regression in Dev Tools #3916

Closed
macohen opened this issue Apr 21, 2023 · 2 comments
Closed

[BUG] Play/Wrench Button Regression in Dev Tools #3916

macohen opened this issue Apr 21, 2023 · 2 comments
Labels
bug Something isn't working v2.7.0

Comments

@macohen
Copy link

macohen commented Apr 21, 2023

Describe the bug

The Play/Wrench buttons do not move as focus is changed from one command to another in dev tools.

To Reproduce
Steps to reproduce the behavior:

  1. Go to the Dev Tools on the 2.7 RC OpenSearch Dashboards
  2. Enter a request into the textarea box on the left (e.g. GET /_cat)
  3. Click the "Play" Button
  4. Enter another request below the first request (e.g. GET /_cat/segments).
  5. The "Play" Button and Wrench do not show up on the second request.

Expected behavior
I expect that the request with focus (where the cursor is) should have the Play button and wrench.

OpenSearch Version
Docker Image: opensearchstaging/opensearch:2.7.0.7747

Dashboards Version
Docker image: opensearchstaging/opensearch-dashboards:2.7.0.6090

Plugins
opensearch-alerting 2.7.0.0
opensearch-anomaly-detection 2.7.0.0
opensearch-asynchronous-search 2.7.0.0
opensearch-cross-cluster-replication 2.7.0.0
opensearch-geospatial 2.7.0.0
opensearch-index-management 2.7.0.0
opensearch-job-scheduler 2.7.0.0
opensearch-knn 2.7.0.0
opensearch-ml 2.7.0.0
opensearch-neural-search 2.7.0.0
opensearch-notifications 2.7.0.0
opensearch-notifications-core 2.7.0.0
opensearch-observability 2.7.0.0
opensearch-performance-analyzer 2.7.0.0
opensearch-reports-scheduler 2.7.0.0
opensearch-security 2.7.0.0
opensearch-security-analytics 2.7.0.0
opensearch-sql 2.7.0.0

Screenshots

Screenshot 2023-04-21 at 11 11 00 AM

Host/Environment (please complete the following information):

  • OS: macOS Ventura
  • Browser and version: Google Chrome Version 112.0.5615.121 (Official Build) (x86_64)

Additional context

Add any other context about the problem here.

@macohen macohen added bug Something isn't working untriaged v2.7.0 labels Apr 21, 2023
kavilla added a commit to kavilla/OpenSearch-Dashboards-1 that referenced this issue Apr 21, 2023
Fix UI bug that did not update the console with the correct
values.

offsetTop was always 0 and the value needed the pixel.

Issue:
opensearch-project#3916

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
kavilla added a commit to kavilla/OpenSearch-Dashboards-1 that referenced this issue Apr 21, 2023
Fix UI bug that did not update the console with the correct
values.

offsetTop was always 0 and the value needed the pixel.

Issue:
opensearch-project#3916

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
kavilla added a commit to kavilla/OpenSearch-Dashboards-1 that referenced this issue Apr 21, 2023
Fix UI bug that did not update the console with the correct
values.

offsetTop was always 0 and the value needed the pixel.

Issue:
opensearch-project#3916

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
@manasvinibs
Copy link
Member

Removing untriaged label as we have a PR open linked to this issue. PR is still work in progress.

@joshuarrrr
Copy link
Member

Fixed by reverting #3929

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working v2.7.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants