Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused x-pack dependencies #448

Closed
tmarkley opened this issue Jun 8, 2021 · 0 comments · Fixed by #449
Closed

Remove unused x-pack dependencies #448

tmarkley opened this issue Jun 8, 2021 · 0 comments · Fixed by #449
Assignees
@tmarkley
Labels
dependencies Pull requests that update a dependency file xpack-cleanup
Milestone
1.x release

Comments

@tmarkley
Copy link
Contributor

tmarkley commented Jun 8, 2021

After investigating a recent Dependabot commit, I realized that there were quite a few direct dependencies in the package.json that were left over from x-pack and not removed.

I used yarn-check to identify the unused dependencies. This isn't a perfect solution because there are a lot of false positives - many of the packages listed as unused were indeed required. I resolved to go through each of them and search the entire code base for a reference and then confirm the usage in the original commit.

Attached is the output from yarn-check.
yarn-check.txt
@tmarkley tmarkley added xpack-cleanup dependencies Pull requests that update a dependency file labels Jun 8, 2021
@tmarkley tmarkley added this to the 1.x release milestone Jun 8, 2021
@tmarkley tmarkley self-assigned this Jun 8, 2021
tmarkley pushed a commit to tmarkley/OpenSearch-Dashboards that referenced this issue Jun 8, 2021
Remove unused dependencies left over from x-pack
f73cb8f 
Issues Resolved: opensearch-project#448

Signed-off-by: Tommy Markley <markleyt@amazon.com>
@tmarkley tmarkley mentioned this issue Jun 8, 2021
Merged
5 tasks
@tmarkley tmarkley linked a pull request Jun 8, 2021 that will close this issue
Remove unused dependencies left over from x-pack #449
Merged
5 tasks
tmarkley pushed a commit that referenced this issue Jun 8, 2021
Remove unused dependencies left over from x-pack
7701ed1 
Issues Resolved: #448

Signed-off-by: Tommy Markley <markleyt@amazon.com>
tmarkley pushed a commit to tmarkley/OpenSearch-Dashboards that referenced this issue Jun 8, 2021
Remove unused dependencies left over from x-pack
055af36 
Issues Resolved: opensearch-project#448

Signed-off-by: Tommy Markley <markleyt@amazon.com>
kavilla pushed a commit that referenced this issue Jun 21, 2021
@kavilla
Remove unused dependencies left over from x-pack
74d7835 
Issues Resolved: #448

Signed-off-by: Tommy Markley <markleyt@amazon.com>
kavilla pushed a commit that referenced this issue Jun 21, 2021
@kavilla
Remove unused dependencies left over from x-pack
93e2701 
Issues Resolved: #448

Signed-off-by: Tommy Markley <markleyt@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmarkley tmarkley

Labels
dependencies Pull requests that update a dependency file xpack-cleanup
Projects
None yet
Milestone
1.x release
Development

Successfully merging a pull request may close this issue.

Remove unused dependencies left over from x-pack tmarkley/OpenSearch-Dashboards
1 participant
@tmarkley