Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Theme version references v7 and v8 #494

Open
kavilla opened this issue Jun 18, 2021 · 6 comments
Open

[BUG] Theme version references v7 and v8 #494

kavilla opened this issue Jun 18, 2021 · 6 comments
Assignees
@ahopp @zuochengding
Labels
bug Something isn't working v3.0.0

Comments

@kavilla
Copy link
Member

kavilla commented Jun 18, 2021

Describe the bug
In Advanced Settings, there is a setting that lets you set the theme version from v7 to v8 implying versions that do not exist yet.

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'Advanced Settings'
  2. Search for 'Theme version'
  3. Click drop down
  4. See v7 and v8 (beta)

Expected behavior
Either no reference to a later version's theme or change the settings to be v1 and Beta. Probably do not need to worry too much about backwards compatibility. If somebody has set their settings to have this and this doesn't load then it should be fine since this is purely for aesthetics. Just make sure it doesn't break BWC.

OpenSearch Version
1.0.0

Dashboards Version
1.0.0

Plugins
n/a

Screenshots
Screen Shot 2021-06-16 at 3 11 01 PM

Host/Environment (please complete the following information):

  • OS: MacOS
  • Browser and version [e.g. 22] Firefox

Additional context

Add any other context about the problem here.
@kavilla kavilla added bug Something isn't working untriaged and removed untriaged labels Jun 18, 2021
@tmarkley tmarkley added the v1.2.0 label Sep 1, 2021
@tmarkley tmarkley added this to the 1.2 Release milestone Sep 1, 2021
@tmarkley tmarkley added v1.3.0 and removed v1.2.0 labels Oct 26, 2021
@zuochengding
Copy link
Contributor

zuochengding commented Nov 23, 2021 •
edited
Loading

Any suggestion for the new theme version name or tag? (for replacing the v7 and v8(beta)
Options:

  1. v1 and v2
  2. v1 and Beta
  3. Default and Beta (since we have only two sets of theme styling)
  4. anything else

@kavilla
Copy link
Member Author

kavilla commented Nov 23, 2021

I think at least v1 and the other option be any variation. I think the concept of version is easier to track compared to default.

@zuochengding
Copy link
Contributor

I personally like the v1 and v2 combination, it makes the file name, variable name more cleaner. But I am open to anything

@zuochengding zuochengding mentioned this issue Nov 24, 2021
Closed
7 tasks
@kavilla kavilla linked a pull request Nov 24, 2021 that will close this issue
Fix opensearch theme version #978
Closed
7 tasks
@jcgraybill
Copy link

Is it really valuable to have two options here? This seems like a holdover from the point-in-time when the OpenSearch Dashboards fork was created. Let's choose one of these and remove this option.

@tmarkley tmarkley removed this from the 1.2 Release milestone Dec 3, 2021
@kavilla kavilla added v2.0.0 and removed v1.3.0 labels Jan 5, 2022
@tmarkley tmarkley removed the v2.0.0 label Apr 14, 2022
kavilla added a commit to kavilla/OpenSearch-Dashboards-1 that referenced this issue May 18, 2022
@kavilla
[Purify] hide option for theme version in settings
83ea474 
There is currently to a PR to remove the v7 and v8 (beta) theme
versions within the application but it is getting stale:
opensearch-project#978

Since the v8 (beta) theme isn't actually planned and has the incorrect
version, we do not want end users to be able to change this setting.
In the essence of time, this will prevent this setting from showing in
the Advanced Settings page but will also not break users who set this
version already (however it will lock them into theme until they switched
by manually updating or deleting the config doc). Removing this setting
will force the default to be v8 (beta).

Temporary fix for:
opensearch-project#494

But it should be removed completely.

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
@kavilla kavilla mentioned this issue May 18, 2022
Merged
7 tasks
kavilla added a commit to kavilla/OpenSearch-Dashboards-1 that referenced this issue May 18, 2022
@kavilla
[Purify] hide option for theme version in settings
117c72e 
There is currently to a PR to remove the v7 and v8 (beta) theme
versions within the application but it is getting stale:
opensearch-project#978

Since the v8 (beta) theme isn't actually planned and has the incorrect
version, we do not want end users to be able to change this setting.
In the essence of time, this will prevent this setting from showing in
the Advanced Settings page but will also not break users who set this
version already (however it will lock them into theme until they switched
by manually updating or deleting the config doc). Removing this setting
will force the default to be v8 (beta).

Temporary fix for:
opensearch-project#494

But it should be removed completely.

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
kavilla added a commit that referenced this issue May 19, 2022
@kavilla
[Purify] hide option for theme version in settings (#1598)
87e5412 
There is currently to a PR to remove the v7 and v8 (beta) theme
versions within the application but it is getting stale:
#978

Since the v8 (beta) theme isn't actually planned and has the incorrect
version, we do not want end users to be able to change this setting.
In the essence of time, this will prevent this setting from showing in
the Advanced Settings page but will also not break users who set this
version already (however it will lock them into theme until they switched
by manually updating or deleting the config doc). Removing this setting
will force the default to be v8 (beta).

Temporary fix for:
#494

But it should be removed completely.

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
@kavilla kavilla added the v3.0.0 label May 19, 2022
@kavilla
Copy link
Member Author

kavilla commented May 19, 2022

#978

This PR was closed because it needed some changes but wasn't prioritized over other changes. As a temp work around we removed this setting in settings in this PR #1598.

The work is close to finish if anyone would like to pull down and continue this PR: #978 but it will need to target 3.0.

opensearch-trigger-bot bot pushed a commit that referenced this issue May 19, 2022
@kavilla @github-actions
[Purify] hide option for theme version in settings (#1598)
5a4b6f5 
There is currently to a PR to remove the v7 and v8 (beta) theme
versions within the application but it is getting stale:
#978

Since the v8 (beta) theme isn't actually planned and has the incorrect
version, we do not want end users to be able to change this setting.
In the essence of time, this will prevent this setting from showing in
the Advanced Settings page but will also not break users who set this
version already (however it will lock them into theme until they switched
by manually updating or deleting the config doc). Removing this setting
will force the default to be v8 (beta).

Temporary fix for:
#494

But it should be removed completely.

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
(cherry picked from commit 87e5412)
opensearch-trigger-bot bot pushed a commit that referenced this issue May 19, 2022
@kavilla @github-actions
[Purify] hide option for theme version in settings (#1598)
05d2587 
There is currently to a PR to remove the v7 and v8 (beta) theme
versions within the application but it is getting stale:
#978

Since the v8 (beta) theme isn't actually planned and has the incorrect
version, we do not want end users to be able to change this setting.
In the essence of time, this will prevent this setting from showing in
the Advanced Settings page but will also not break users who set this
version already (however it will lock them into theme until they switched
by manually updating or deleting the config doc). Removing this setting
will force the default to be v8 (beta).

Temporary fix for:
#494

But it should be removed completely.

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
(cherry picked from commit 87e5412)
kavilla added a commit that referenced this issue May 19, 2022
@opensearch-trigger-bot @kavilla
[Purify] hide option for theme version in settings (#1598) (#1603)
45e0f28 
There is currently to a PR to remove the v7 and v8 (beta) theme
versions within the application but it is getting stale:
#978

Since the v8 (beta) theme isn't actually planned and has the incorrect
version, we do not want end users to be able to change this setting.
In the essence of time, this will prevent this setting from showing in
the Advanced Settings page but will also not break users who set this
version already (however it will lock them into theme until they switched
by manually updating or deleting the config doc). Removing this setting
will force the default to be v8 (beta).

Temporary fix for:
#494

But it should be removed completely.

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
(cherry picked from commit 87e5412)

Co-authored-by: Kawika Avilla <kavilla414@gmail.com>
kavilla added a commit that referenced this issue May 19, 2022
@opensearch-trigger-bot @kavilla
[Purify] hide option for theme version in settings (#1598) (#1604)
16a945b 
There is currently to a PR to remove the v7 and v8 (beta) theme
versions within the application but it is getting stale:
#978

Since the v8 (beta) theme isn't actually planned and has the incorrect
version, we do not want end users to be able to change this setting.
In the essence of time, this will prevent this setting from showing in
the Advanced Settings page but will also not break users who set this
version already (however it will lock them into theme until they switched
by manually updating or deleting the config doc). Removing this setting
will force the default to be v8 (beta).

Temporary fix for:
#494

But it should be removed completely.

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
(cherry picked from commit 87e5412)

Co-authored-by: Kawika Avilla <kavilla414@gmail.com>
kavilla added a commit to kavilla/OpenSearch-Dashboards-1 that referenced this issue Jun 8, 2022
@kavilla
[Purify] hide option for theme version in settings (opensearch-projec…
ed09023 
…t#1598)

There is currently to a PR to remove the v7 and v8 (beta) theme
versions within the application but it is getting stale:
opensearch-project#978

Since the v8 (beta) theme isn't actually planned and has the incorrect
version, we do not want end users to be able to change this setting.
In the essence of time, this will prevent this setting from showing in
the Advanced Settings page but will also not break users who set this
version already (however it will lock them into theme until they switched
by manually updating or deleting the config doc). Removing this setting
will force the default to be v8 (beta).

Temporary fix for:
opensearch-project#494

But it should be removed completely.

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
kavilla added a commit to kavilla/OpenSearch-Dashboards-1 that referenced this issue Jun 16, 2022
@kavilla
[Purify] hide option for theme version in settings (opensearch-projec…
89c248a 
…t#1598)

There is currently to a PR to remove the v7 and v8 (beta) theme
versions within the application but it is getting stale:
opensearch-project#978

Since the v8 (beta) theme isn't actually planned and has the incorrect
version, we do not want end users to be able to change this setting.
In the essence of time, this will prevent this setting from showing in
the Advanced Settings page but will also not break users who set this
version already (however it will lock them into theme until they switched
by manually updating or deleting the config doc). Removing this setting
will force the default to be v8 (beta).

Temporary fix for:
opensearch-project#494

But it should be removed completely.

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
@tmarkley
Copy link
Contributor

tmarkley commented Dec 7, 2022

I'm taking a look at this - going to try to get the changes in a state that is ready for a PR.

@tmarkley tmarkley mentioned this issue Dec 7, 2022
Open
tmarkley added a commit to tmarkley/OpenSearch-Dashboards that referenced this issue Dec 8, 2022
@tmarkley
Renames v7 theme, removes beta theme
580f56a 
* Forces the v1 (the old v7) theme for all users, keeps the advanced
setting ui hidden.
* Keeps the theme switching logic for when the OUI cascadia theme is
ready.

Resolves opensearch-project#494

Signed-off-by: Tommy Markley <5437176+tmarkley@users.noreply.github.com>
tmarkley added a commit to tmarkley/OpenSearch-Dashboards that referenced this issue Dec 8, 2022
@tmarkley
Renames v7 theme, removes beta theme
90afde5 
* Forces the v1 (the old v7) theme for all users, keeps the advanced
setting ui hidden.
* Keeps the theme switching logic for when the OUI cascadia theme is
ready.

Resolves opensearch-project#494

Signed-off-by: Tommy Markley <5437176+tmarkley@users.noreply.github.com>
@tmarkley tmarkley mentioned this issue Dec 8, 2022
Closed
8 tasks
tmarkley added a commit to tmarkley/OpenSearch-Dashboards that referenced this issue Dec 12, 2022
@tmarkley
Renames v7 theme, removes beta theme
aba71ca 
* Forces the v1 (the old v7) theme for all users, keeps the advanced
setting ui hidden.
* Keeps the theme switching logic for when the OUI cascadia theme is
ready.

Resolves opensearch-project#494

Signed-off-by: Tommy Markley <5437176+tmarkley@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ahopp ahopp

@zuochengding zuochengding

Labels
bug Something isn't working v3.0.0
Projects
None yet
Milestone
No milestone
5 participants
@tmarkley @ahopp @kavilla @zuochengding @jcgraybill