Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Dev tools console autocomplete doesn't work well with aliases #5567

Closed
BSFishy opened this issue Dec 1, 2023 · 3 comments · Fixed by #5568
Closed

[BUG] Dev tools console autocomplete doesn't work well with aliases #5567

BSFishy opened this issue Dec 1, 2023 · 3 comments · Fixed by #5568
Assignees
Labels
bug Something isn't working v2.12.0

Comments

@BSFishy
Copy link
Contributor

BSFishy commented Dec 1, 2023

Describe the bug

The console autocomplete doesn't work well with aliases. For example, if I have an alias called alias to a index called index, if I try to type in requests related to the alias alias, I won't get very much autocomplete. For example, if I start typing in GET alias, I won't get auto-completion on alias. Further, if I try creating a search request on that alias, I won't get auto-completion on field names.

To Reproduce

  1. Create an index and populate it with data

  2. Create an alias pointing to the index

  3. Go to dev tools console

  4. Type in GET [alias name]/_search and notice you don't get auto-completion on the alias name

  5. Start writing in a search query. I used:

    {
      "query": {
        "term": {
          "": {
            "value": "VALUE"
          }
        }
      }
    }

    Notice in the empty string you don't get auto-completion on field names.

  6. Now try steps 4-5 with the index instead of the alias and notice auto-completion works as expected.

Expected behavior

I would expect autocomplete to work the same as if I were using an index rather than alias.

OpenSearch Version

2.8.0

Dashboards Version

Main

Plugins

OSD:

  • Security

OS: Everything included with the tarball distribution

Screenshots

Screenshot (189)
(I should be getting an autocomplete prompt for the field name)

Host/Environment (please complete the following information):

  • OS: Windows 10
  • Browser and version: Firefox 115.4

Additional context

This seems to have worked in a previous release, although I haven't done extensive testing to figure out where.

@BSFishy BSFishy added bug Something isn't working untriaged labels Dec 1, 2023
kishor82 added a commit to kishor82/OpenSearch-Dashboards that referenced this issue Dec 3, 2023
kishor82 added a commit to kishor82/OpenSearch-Dashboards that referenced this issue Dec 3, 2023
kishor82 added a commit to kishor82/OpenSearch-Dashboards that referenced this issue Dec 3, 2023
kishor82 added a commit to kishor82/OpenSearch-Dashboards that referenced this issue Dec 4, 2023
Signed-off-by: kishor82 <kishorrathva8298@gmail.com>
@joshuarrrr
Copy link
Member

joshuarrrr commented Dec 5, 2023

@kishor82 Thanks for the quick fix! I'll take a look at the PR in the next couple days. Do you mind adding a comment here so I can assign you?

kishor82 added a commit to kishor82/OpenSearch-Dashboards that referenced this issue Dec 6, 2023
Signed-off-by: kishor82 <kishorrathva8298@gmail.com>
kishor82 added a commit to kishor82/OpenSearch-Dashboards that referenced this issue Dec 6, 2023
Signed-off-by: kishor82 <kishorrathva8298@gmail.com>
kishor82 added a commit to kishor82/OpenSearch-Dashboards that referenced this issue Dec 7, 2023
Signed-off-by: kishor82 <kishorrathva8298@gmail.com>
@kishor82
Copy link
Contributor

kishor82 commented Dec 7, 2023

@joshuarrrr Thanks for checking it out! I've added a comment as requested. If there's anything specific you'd like me to address or if you have any further questions, feel free to let me know.

@joshuarrrr
Copy link
Member

Looks like this bug was introduced in v2.9.0 via #4008

kishor82 added a commit to kishor82/OpenSearch-Dashboards that referenced this issue Dec 12, 2023
Signed-off-by: kishor82 <kishorrathva8298@gmail.com>
kishor82 added a commit to kishor82/OpenSearch-Dashboards that referenced this issue Dec 12, 2023
Signed-off-by: Kishor Rathva <kishorrathva8298@gmail.com>
kishor82 added a commit to kishor82/OpenSearch-Dashboards that referenced this issue Dec 13, 2023
Signed-off-by: Kishor Rathva <kishorrathva8298@gmail.com>
kishor82 added a commit to kishor82/OpenSearch-Dashboards that referenced this issue Dec 13, 2023
Signed-off-by: Kishor Rathva <kishorrathva8298@gmail.com>
kishor82 added a commit to kishor82/OpenSearch-Dashboards that referenced this issue Dec 13, 2023
Signed-off-by: Kishor Rathva <kishorrathva8298@gmail.com>
kishor82 added a commit to kishor82/OpenSearch-Dashboards that referenced this issue Dec 14, 2023
Signed-off-by: Kishor Rathva <kishorrathva8298@gmail.com>
ananzh pushed a commit that referenced this issue Dec 14, 2023
* fix: Dev tools console autocomplete issue #5567
* Added CHANGELOG
* Added test for retrieveAutoCompleteInfo
* Refactored tests
* Added suggested changes.
---------

Signed-off-by: Kishor Rathva <kishorrathva8298@gmail.com>
opensearch-trigger-bot bot pushed a commit that referenced this issue Dec 14, 2023
* fix: Dev tools console autocomplete issue #5567
* Added CHANGELOG
* Added test for retrieveAutoCompleteInfo
* Refactored tests
* Added suggested changes.
---------

Signed-off-by: Kishor Rathva <kishorrathva8298@gmail.com>
(cherry picked from commit a5c45a3)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
manasvinibs pushed a commit that referenced this issue Dec 14, 2023
* fix: Dev tools console autocomplete issue #5567
* Added CHANGELOG
* Added test for retrieveAutoCompleteInfo
* Refactored tests
* Added suggested changes.
---------


(cherry picked from commit a5c45a3)

Signed-off-by: Kishor Rathva <kishorrathva8298@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working v2.12.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants