Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Discover no longer shows new lines in a field #7177

Closed
joshuali925 opened this issue Jul 4, 2024 · 2 comments · Fixed by #7207
Closed

[BUG] Discover no longer shows new lines in a field #7177

joshuali925 opened this issue Jul 4, 2024 · 2 comments · Fixed by #7207
Assignees
Labels
bug Something isn't working v2.16.0

Comments

@joshuali925
Copy link
Member

joshuali925 commented Jul 4, 2024

Describe the bug

Discover no longer shows new lines in the selected field

To Reproduce
Steps to reproduce the behavior:

  1. Go to devtools
  2. run
PUT /multi-line-index/_doc/1
{
  "message": "This \n is \n a \n test \n message"
}
  1. create index pattern and search in discover
  2. select message field in the left side bar
  3. see message is displayed in one line

Expected behavior
old behavior as in 1.x, where message is correctly displayed with line breaks when selected

OpenSearch Version
main

Dashboards Version
main

Plugins

none

Screenshots

image

Host/Environment (please complete the following information):

  • OS: [e.g. iOS]
  • Browser and version [e.g. 22]

Additional context

Add any other context about the problem here.

@joshuali925 joshuali925 added bug Something isn't working untriaged labels Jul 4, 2024
@joshuali925
Copy link
Member Author

joshuali925 commented Jul 4, 2024

the functionality came from

but in newer versions, this class is no longer used or defined, and there are no similar classes.

it was removed in #5086. @ashwin-pc do you know if it's intended to not use white-space: pre-wrap; on table cells anymore?

Edit: confirmed it's not intended

@stevesimpson418
Copy link

I would like to add this is an issue in 2.x also, tested and verified on version 2.3

joshuali925 added a commit to joshuali925/OpenSearch-Dashboards that referenced this issue Jul 9, 2024
fixes opensearch-project#7177

Signed-off-by: Joshua Li <joshuali925@gmail.com>
@ananzh ananzh closed this as completed in 4ff4c3c Jul 25, 2024
opensearch-trigger-bot bot pushed a commit that referenced this issue Jul 25, 2024
* fix(discover): break new lines in table cell

fixes #7177

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* Changeset file for PR #7207 created/updated

---------

Signed-off-by: Joshua Li <joshuali925@gmail.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 4ff4c3c)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this issue Jul 25, 2024
* fix(discover): break new lines in table cell

fixes #7177

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* Changeset file for PR #7207 created/updated

---------

Signed-off-by: Joshua Li <joshuali925@gmail.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 4ff4c3c)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ananzh pushed a commit that referenced this issue Jul 25, 2024
* fix(discover): break new lines in table cell

fixes #7177



* Changeset file for PR #7207 created/updated

---------



(cherry picked from commit 4ff4c3c)

Signed-off-by: Joshua Li <joshuali925@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Qxisylolo pushed a commit to Qxisylolo/OpenSearch-Dashboards that referenced this issue Aug 1, 2024
* fix(discover): break new lines in table cell

fixes opensearch-project#7177

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* Changeset file for PR opensearch-project#7207 created/updated

---------

Signed-off-by: Joshua Li <joshuali925@gmail.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working v2.16.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants