Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MDS][Enhancement] Redirection to query workbench should be able to select specific cluster #8602

Open
RyanL1997 opened this issue Oct 16, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@RyanL1997
Copy link
Contributor

The problem to resolve

Under the MDS environment, when the redirection from datasource management to query workbench happens, there is a cluster selection mismatch.

Backgroud of the issue

In 2.16, data source management plugin introduced the direct query connection with MDS support. For supporting MDS, it was originally designed to use a datasource picker in PR: [MDS] Observability Datasource Plugin migration with MDS support #7143, shown as the following picture:
Screenshot 2024-10-15 at 5 52 31 PM
However, the above design was replaced by PR: Display direct query connections of local cluster in data sources page #8059. The following picture shows the datasource picker was removed:
Screenshot 2024-10-15 at 6 17 27 PM

According to this, when redirection to query workbench happens in data source management, query workbench will always treat as the targeting cluster as the the current global value of the current cluster, which in the above case, the global value is not being setup, so it will always select the default cluster.

Steps for reproduce

  1. Enable MDS and connect to a remote cluster.
  2. Get a flint setup domain on local cluster
  3. Go to Datasource management page and select the flint datasource in the "direct query connections" tab for the local cluster
  4. Click into the detailed connection page, and click on the "Create Acceleration" card/button, so that it will pop up the Flint acceleration creation flow as a flyout.
  5. Try to filling the required field, for a creation of Skipping/MV/CV/
  6. Select "Preview SQL Definition" and click on "Edit in query workbench"
  7. When the redirection happens, even the query that generated in datasource management for local cluster's flint datasource is pasted in query workbench,. However, the cluster picker in query workbench shows the user is querying in the remote cluster, since that is the default cluster.
Screen.Recording.2024-10-15.at.6.18.49.PM.mov

How to resolve this issue

@RyanL1997 RyanL1997 added the enhancement New feature or request label Oct 16, 2024
@RyanL1997 RyanL1997 changed the title [MDS][Enhancement] Redirection to query workbench should be able to select remote cluster [MDS][Enhancement] Redirection to query workbench should be able to select specific cluster Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant