-
Notifications
You must be signed in to change notification settings - Fork 885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MDS] Observability Datasource Plugin migration with MDS support #7143
[MDS] Observability Datasource Plugin migration with MDS support #7143
Conversation
Signed-off-by: Ryan Liang <jiallian@amazon.com>
…ource Signed-off-by: Ryan Liang <jiallian@amazon.com>
Signed-off-by: Ryan Liang <jiallian@amazon.com>
Signed-off-by: Ryan Liang <jiallian@amazon.com>
Signed-off-by: Ryan Liang <jiallian@amazon.com>
Signed-off-by: Ryan Liang <jiallian@amazon.com>
Signed-off-by: Ryan Liang <jiallian@amazon.com>
Signed-off-by: Ryan Liang <jiallian@amazon.com>
Signed-off-by: Ryan Liang <jiallian@amazon.com>
Signed-off-by: Ryan Liang <jiallian@amazon.com>
Signed-off-by: Ryan Liang <jiallian@amazon.com>
Signed-off-by: Ryan Liang <jiallian@amazon.com>
Signed-off-by: Ryan Liang <jiallian@amazon.com>
Signed-off-by: Ryan Liang <jiallian@amazon.com>
Signed-off-by: Ryan Liang <jiallian@amazon.com>
Signed-off-by: Ryan Liang <jiallian@amazon.com>
ℹ️ Manual Changeset Creation ReminderPlease ensure manual commit for changeset file 7143.yml under folder changelogs/fragments to complete this PR. If you want to use the available OpenSearch Changeset Bot App to avoid manual creation of changeset file you can install it in your forked repository following this link. For more information about formatting of changeset files, please visit OpenSearch Auto Changeset and Release Notes Tool. |
❌ Invalid Prefix For Manual Changeset CreationInvalid description prefix. Found "feat". Only "skip" entry option is permitted for manual commit of changeset files. If you were trying to skip the changelog entry, please use the "skip" entry option in the ##Changelog section of your PR description. |
❌ Invalid Prefix For Manual Changeset CreationInvalid description prefix. Found "feat". Only "skip" entry option is permitted for manual commit of changeset files. If you were trying to skip the changelog entry, please use the "skip" entry option in the ##Changelog section of your PR description. |
1 similar comment
❌ Invalid Prefix For Manual Changeset CreationInvalid description prefix. Found "feat". Only "skip" entry option is permitted for manual commit of changeset files. If you were trying to skip the changelog entry, please use the "skip" entry option in the ##Changelog section of your PR description. |
❌ Entry Too LongEntry is 146 characters long, which is 46 characters longer than the maximum allowed length of 100 characters. Please revise your entry to be within the maximum length. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RyanL1997 Why in the "disable feature flag" video, there's still MDS create data source available? I thought the purpose is the hide/disable "create data source", when data_source.enabled: false
, or this will be the next step?
Hi @zhongnansu, good catch. I uploaded the wrong video... and I just corrected that in PR description. |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-7143-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 9ac318456ce93714223b801953fa5973f855bf60
# Push it to GitHub
git push --set-upstream origin backport/backport-7143-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x Then, create a pull request where the |
…nsearch-project#7143) * Observability Datasource Plugin migration with MDS support Signed-off-by: Ryan Liang <jiallian@amazon.com> * Switch to use doc services for doc links of configuration of s3 datasource Signed-off-by: Ryan Liang <jiallian@amazon.com> * Add tests for home panel Signed-off-by: Ryan Liang <jiallian@amazon.com> * Fix the snapshot for mds Signed-off-by: Ryan Liang <jiallian@amazon.com> * Add tests for data source creation panel Signed-off-by: Ryan Liang <jiallian@amazon.com> * Add tests for dq data connection table Signed-off-by: Ryan Liang <jiallian@amazon.com> * Add tests for dq configuration Signed-off-by: Ryan Liang <jiallian@amazon.com> * Add readonly for s3glue doc link Signed-off-by: Ryan Liang <jiallian@amazon.com> * Add tests for s3 prometheus creation and review Signed-off-by: Ryan Liang <jiallian@amazon.com> * Fix mount feature flag behavior and tests Signed-off-by: Ryan Liang <jiallian@amazon.com> * Shorten file names Signed-off-by: Ryan Liang <jiallian@amazon.com> * Shorten file names again Signed-off-by: Ryan Liang <jiallian@amazon.com> * Experiment 1 Signed-off-by: Ryan Liang <jiallian@amazon.com> * Fix the visbuilder failure 1 Signed-off-by: Ryan Liang <jiallian@amazon.com> * Fix the setter of datasource setup in vis_type_timeseries Signed-off-by: Ryan Liang <jiallian@amazon.com> * Synced branch Signed-off-by: Ryan Liang <jiallian@amazon.com> * Fix the readonly in doc link and add change log Signed-off-by: Ryan Liang <jiallian@amazon.com> * Fix the create opensearch datasource's cancel button redirection Signed-off-by: Ryan Liang <jiallian@amazon.com> * Add more test cases for breadscrumb changes and mount behavior based on the plugin registration Signed-off-by: Ryan Liang <jiallian@amazon.com> --------- Signed-off-by: Ryan Liang <jiallian@amazon.com>
…S support for Data Connection Table (#7371) * [MDS] Observability Datasource Plugin migration with MDS support (#7143) * Observability Datasource Plugin migration with MDS support Signed-off-by: Ryan Liang <jiallian@amazon.com> * Switch to use doc services for doc links of configuration of s3 datasource Signed-off-by: Ryan Liang <jiallian@amazon.com> * Add tests for home panel Signed-off-by: Ryan Liang <jiallian@amazon.com> * Fix the snapshot for mds Signed-off-by: Ryan Liang <jiallian@amazon.com> * Add tests for data source creation panel Signed-off-by: Ryan Liang <jiallian@amazon.com> * Add tests for dq data connection table Signed-off-by: Ryan Liang <jiallian@amazon.com> * Add tests for dq configuration Signed-off-by: Ryan Liang <jiallian@amazon.com> * Add readonly for s3glue doc link Signed-off-by: Ryan Liang <jiallian@amazon.com> * Add tests for s3 prometheus creation and review Signed-off-by: Ryan Liang <jiallian@amazon.com> * Fix mount feature flag behavior and tests Signed-off-by: Ryan Liang <jiallian@amazon.com> * Shorten file names Signed-off-by: Ryan Liang <jiallian@amazon.com> * Shorten file names again Signed-off-by: Ryan Liang <jiallian@amazon.com> * Experiment 1 Signed-off-by: Ryan Liang <jiallian@amazon.com> * Fix the visbuilder failure 1 Signed-off-by: Ryan Liang <jiallian@amazon.com> * Fix the setter of datasource setup in vis_type_timeseries Signed-off-by: Ryan Liang <jiallian@amazon.com> * Synced branch Signed-off-by: Ryan Liang <jiallian@amazon.com> * Fix the readonly in doc link and add change log Signed-off-by: Ryan Liang <jiallian@amazon.com> * Fix the create opensearch datasource's cancel button redirection Signed-off-by: Ryan Liang <jiallian@amazon.com> * Add more test cases for breadscrumb changes and mount behavior based on the plugin registration Signed-off-by: Ryan Liang <jiallian@amazon.com> --------- Signed-off-by: Ryan Liang <jiallian@amazon.com> * [MDS] Fix the dsm plugin setup when mds feature flag is disabled (#7163) * Fix the dsm plugin setup when mds feature flag is disabled Signed-off-by: Ryan Liang <jiallian@amazon.com> * Changeset file for PR #7163 created/updated --------- Signed-off-by: Ryan Liang <jiallian@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> * Changeset file for PR #7371 created/updated * Fix snapshots Signed-off-by: Ryan Liang <jiallian@amazon.com> --------- Signed-off-by: Ryan Liang <jiallian@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
…S support for Data Connection Table (#7371) * [MDS] Observability Datasource Plugin migration with MDS support (#7143) * Observability Datasource Plugin migration with MDS support Signed-off-by: Ryan Liang <jiallian@amazon.com> * Switch to use doc services for doc links of configuration of s3 datasource Signed-off-by: Ryan Liang <jiallian@amazon.com> * Add tests for home panel Signed-off-by: Ryan Liang <jiallian@amazon.com> * Fix the snapshot for mds Signed-off-by: Ryan Liang <jiallian@amazon.com> * Add tests for data source creation panel Signed-off-by: Ryan Liang <jiallian@amazon.com> * Add tests for dq data connection table Signed-off-by: Ryan Liang <jiallian@amazon.com> * Add tests for dq configuration Signed-off-by: Ryan Liang <jiallian@amazon.com> * Add readonly for s3glue doc link Signed-off-by: Ryan Liang <jiallian@amazon.com> * Add tests for s3 prometheus creation and review Signed-off-by: Ryan Liang <jiallian@amazon.com> * Fix mount feature flag behavior and tests Signed-off-by: Ryan Liang <jiallian@amazon.com> * Shorten file names Signed-off-by: Ryan Liang <jiallian@amazon.com> * Shorten file names again Signed-off-by: Ryan Liang <jiallian@amazon.com> * Experiment 1 Signed-off-by: Ryan Liang <jiallian@amazon.com> * Fix the visbuilder failure 1 Signed-off-by: Ryan Liang <jiallian@amazon.com> * Fix the setter of datasource setup in vis_type_timeseries Signed-off-by: Ryan Liang <jiallian@amazon.com> * Synced branch Signed-off-by: Ryan Liang <jiallian@amazon.com> * Fix the readonly in doc link and add change log Signed-off-by: Ryan Liang <jiallian@amazon.com> * Fix the create opensearch datasource's cancel button redirection Signed-off-by: Ryan Liang <jiallian@amazon.com> * Add more test cases for breadscrumb changes and mount behavior based on the plugin registration Signed-off-by: Ryan Liang <jiallian@amazon.com> --------- Signed-off-by: Ryan Liang <jiallian@amazon.com> * [MDS] Fix the dsm plugin setup when mds feature flag is disabled (#7163) * Fix the dsm plugin setup when mds feature flag is disabled Signed-off-by: Ryan Liang <jiallian@amazon.com> * Changeset file for PR #7163 created/updated --------- Signed-off-by: Ryan Liang <jiallian@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> * Changeset file for PR #7371 created/updated * Fix snapshots Signed-off-by: Ryan Liang <jiallian@amazon.com> --------- Signed-off-by: Ryan Liang <jiallian@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 704f2fa) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…S support for Data Connection Table (#7371) (#7384) * [MDS] Observability Datasource Plugin migration with MDS support (#7143) * Observability Datasource Plugin migration with MDS support * Switch to use doc services for doc links of configuration of s3 datasource * Add tests for home panel * Fix the snapshot for mds * Add tests for data source creation panel * Add tests for dq data connection table * Add tests for dq configuration * Add readonly for s3glue doc link * Add tests for s3 prometheus creation and review * Fix mount feature flag behavior and tests * Shorten file names * Shorten file names again * Experiment 1 * Fix the visbuilder failure 1 * Fix the setter of datasource setup in vis_type_timeseries * Synced branch * Fix the readonly in doc link and add change log * Fix the create opensearch datasource's cancel button redirection * Add more test cases for breadscrumb changes and mount behavior based on the plugin registration --------- * [MDS] Fix the dsm plugin setup when mds feature flag is disabled (#7163) * Fix the dsm plugin setup when mds feature flag is disabled * Changeset file for PR #7163 created/updated --------- * Changeset file for PR #7371 created/updated * Fix snapshots --------- (cherry picked from commit 704f2fa) Signed-off-by: Ryan Liang <jiallian@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
@RyanL1997 failed backport, did we do manual backport to release branch |
Looks like 2.x was manually backported and that was backported to 2.16 successfully. |
Signed-off-by: Ryan Liang jiallian@amazon.com
Description
Observability Datasource Plugin migration with MDS support
Issues Resolved
Demo
Testing the changes
Feature flag enabled:
Screen.Recording.2024-07-01.at.11.06.28.AM.mov
Feature flag disabled:
Screen.Recording.2024-07-01.at.3.20.09.PM.mov
Changelog
Check List
yarn test:jest
yarn test:jest_integration