Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Branding] Remove or allow to disable url validation #989

Closed
Arbuzov opened this issue Dec 1, 2021 · 1 comment
Closed

[Branding] Remove or allow to disable url validation #989

Arbuzov opened this issue Dec 1, 2021 · 1 comment
Labels
branding bug Something isn't working ux / ui Improvements or additions to user experience, flows, components, UI elements

Comments

@Arbuzov
Copy link

Arbuzov commented Dec 1, 2021 •
edited
Loading

This related to #372

isUrlValid function rejects some valid values

The validation does not pass if I set relative URLs or embed image into page like url('data:image/svg+xml;base64,.....==')

The validation should be more flexible, or the user must be able to disable validation.
@Arbuzov Arbuzov added the enhancement New feature or request label Dec 1, 2021
@Arbuzov
Copy link
Author

Arbuzov commented Dec 2, 2021

I suppose this should be a bug

@seanneumann seanneumann added bug Something isn't working and removed enhancement New feature or request labels Dec 7, 2021
@Arbuzov Arbuzov mentioned this issue Dec 12, 2021
Closed
7 tasks
@kavilla kavilla linked a pull request Dec 13, 2021 that will close this issue
[Branding] Update resource validation procedure. #1019
Closed
7 tasks
@kavilla kavilla added branding ux / ui Improvements or additions to user experience, flows, components, UI elements labels Dec 21, 2021
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this issue Feb 10, 2022
@monfera
fix: chart state and series functions cleanup (opensearch-project#989)
42a7af0
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this issue Feb 10, 2022
@semantic-release-bot
chore(release): 24.5.0 [skip ci]
b3d1a20 
# [24.5.0](elastic/elastic-charts@v24.4.0...v24.5.0) (2021-01-30)

### Bug Fixes

* add theme min radius to point shape ([opensearch-project#996](elastic/elastic-charts#996)) ([98089a9](elastic/elastic-charts@98089a9))
* align tooltip z-index to EUI tooltip z-index ([opensearch-project#931](elastic/elastic-charts#931)) ([f7f1f6f](elastic/elastic-charts@f7f1f6f))
* chart state and series functions cleanup ([opensearch-project#989](elastic/elastic-charts#989)) ([42a7af0](elastic/elastic-charts@42a7af0))
* create unique ids for dot icons ([opensearch-project#971](elastic/elastic-charts#971)) ([0b3e00f](elastic/elastic-charts@0b3e00f))
* external tooltip legend extra value sync ([opensearch-project#993](elastic/elastic-charts#993)) ([7e1096e](elastic/elastic-charts@7e1096e))
* **legend:** disable focus and keyboard navigation for legend in partition ch… ([opensearch-project#952](elastic/elastic-charts#952)) ([dfff3e2](elastic/elastic-charts@dfff3e2))
* **legend:** hierarchical legend order should follow the tree paths ([opensearch-project#947](elastic/elastic-charts#947)) ([7b70186](elastic/elastic-charts@7b70186)), closes [opensearch-project#944](elastic/elastic-charts#944)
* **legend:** remove ids for circles ([opensearch-project#973](elastic/elastic-charts#973)) ([ed98481](elastic/elastic-charts@ed98481))

### Features

* **cursor:** improve theme styling for crosshair ([opensearch-project#980](elastic/elastic-charts#980)) ([0248ad6](elastic/elastic-charts@0248ad6))
* **legend:**  display pie chart legend extra ([opensearch-project#939](elastic/elastic-charts#939)) ([672a4df](elastic/elastic-charts@672a4df))
* **legend:** add keyboard navigation ([opensearch-project#880](elastic/elastic-charts#880)) ([b471a94](elastic/elastic-charts@b471a94))
* **partition:** Flame and icicle chart ([opensearch-project#965](elastic/elastic-charts#965)) ([9e8b1f7](elastic/elastic-charts@9e8b1f7))
* **partition:** legend hover options ([opensearch-project#978](elastic/elastic-charts#978)) ([acd1339](elastic/elastic-charts@acd1339))
* **xy:** support multiple point shapes on line, area and bubble charts ([opensearch-project#988](elastic/elastic-charts#988)) ([4f23b4f](elastic/elastic-charts@4f23b4f))
@Arbuzov Arbuzov closed this as not planned Won't fix, can't repro, duplicate, stale May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
branding bug Something isn't working ux / ui Improvements or additions to user experience, flows, components, UI elements
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Branding] Update resource validation procedure. Arbuzov/OpenSearch-Dashboards
3 participants
@seanneumann @Arbuzov @kavilla