Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rename] Refactored src/plugins/vis_type_timeseries directory #100

Merged
merged 2 commits into from
Mar 12, 2021
Merged

[Rename] Refactored src/plugins/vis_type_timeseries directory #100

merged 2 commits into from
Mar 12, 2021

Conversation

mihirsoni
Copy link
Contributor

Signed-off-by: Mihir Soni mihirsoni.123@gmail.com

Issue #, if available: #37

Description of changes: Refactored src/plugins/vis_type_timeseries directory

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com>
@@ -20,7 +20,7 @@
import { getEsShardTimeout } from './get_es_shard_timeout';
Copy link
Member

@ananzh ananzh Mar 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getEsShardTimeout --> getOpenSearchShardTimeout
get_es_shard_timeout --> get_opensearch_shard_timeout
also the file name needs change

Copy link
Member

@ananzh ananzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Miss some Es. Others look good.

Copy link
Contributor

@boktorbb boktorbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix Anan comments but looks good otherwise

@mihirsoni mihirsoni merged commit 573fa7d into opensearch-project:dashboards Mar 12, 2021
@mihirsoni mihirsoni deleted the src/plugins/vis_type_timeseries branch March 12, 2021 08:03
kavilla referenced this pull request in kavilla/OpenSearch-Dashboards Mar 19, 2021
* [Rename] Refactored src/plugins/vis_type_timeseries directory

Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com>
kavilla pushed a commit that referenced this pull request Mar 20, 2021
* [Rename] Refactored src/plugins/vis_type_timeseries directory

Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com>
mihirsoni added a commit that referenced this pull request Mar 20, 2021
* [Rename] Refactored src/plugins/vis_type_timeseries directory

Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com>
raintygao pushed a commit to raintygao/OpenSearch-Dashboards that referenced this pull request Aug 25, 2023
* change workspace id size to 6

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>

* added license header

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>

---------

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
SuZhou-Joe pushed a commit to SuZhou-Joe/OpenSearch-Dashboards that referenced this pull request Sep 14, 2023
* change workspace id size to 6

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>

* added license header

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>

---------

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
Hailong-am pushed a commit to Hailong-am/OpenSearch-Dashboards that referenced this pull request Sep 15, 2023
* change workspace id size to 6

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>

* added license header

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>

---------

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants