Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backwards Compatibility] restore URL forwarding from legacy app #1021

Merged
merged 1 commit into from
Dec 16, 2021
Merged

[Backwards Compatibility] restore URL forwarding from legacy app #1021

merged 1 commit into from
Dec 16, 2021

Conversation

kavilla
Copy link
Member

@kavilla kavilla commented Dec 13, 2021

Description

Forwarding legacy app to the current format of the application.
This enables the usage of stored URLs and other links that referenced
the format of the application URL that mentioned the application name.

Since we changed the URL forwarding we changed this value and released.
So incase forks were made and depended on this legacy formatted reference
of the application. It will still work. There are also references of the
application.

Signed-off-by: Kawika Avilla kavilla414@gmail.com

Issues Resolved

#1013

Check List

  • New functionality includes testing.
    • All tests pass
      • yarn test:jest
      • yarn test:jest_integration
      • yarn test:ftr
  • New functionality has been documented.
  • Commits are signed per the DCO using --signoff

@kavilla
[Backwards Compatibility] restore URL forwarding from legacy app
d00211c 
Forwarding legacy app to the current format of the application.
This enables the usage of stored URLs and other links that referenced
the format of the application URL that mentioned the application name.

Since we changed the URL forwarding we changed this value and released.
So incase forks were made and depended on this legacy formatted reference
of the application. It will still work. There are also references of the
application.

Issue resolved:
opensearch-project#1013

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
@kavilla kavilla requested a review from a team as a code owner December 13, 2021 09:18
@kavilla kavilla added backwards-compatibility bug Something isn't working labels Dec 13, 2021
@kavilla kavilla linked an issue Dec 13, 2021 that may be closed by this pull request
[BUG] app/kibana should foward to new format #1013
Closed
@kavilla
Copy link
Member Author

kavilla commented Dec 13, 2021 •
edited
Loading

Need to add to link ignore file the test links.

just re-ran it. it timed out previously on no change url

tmarkley
tmarkley approved these changes Dec 14, 2021
View reviewed changes
Copy link
Contributor

@tmarkley tmarkley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Do we need to document this anywhere?

boktorbb
boktorbb approved these changes Dec 15, 2021
View reviewed changes
Copy link
Contributor

@boktorbb boktorbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks for the testing

@kavilla kavilla merged commit b8f276f into opensearch-project:main Dec 16, 2021
@kavilla kavilla deleted the avillk/legacy_url_forward branch January 10, 2022 17:34
kavilla added a commit to kavilla/OpenSearch-Dashboards-1 that referenced this pull request Jan 10, 2022
@kavilla
[1.x][Backwards Compatibility] restore URL forwarding from legacy app
bd72294 
Forwarding legacy app to the current format of the application.
This enables the usage of stored URLs and other links that referenced
the format of the application URL that mentioned the application name.

Since we changed the URL forwarding we changed this value and released.
So incase forks were made and depended on this legacy formatted reference
of the application. It will still work. There are also references of the
application.

Issue resolved:
opensearch-project#1013

Backport PR:
opensearch-project#1021

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
@kavilla kavilla mentioned this pull request Jan 10, 2022
Merged
7 tasks
kavilla added a commit that referenced this pull request Jan 13, 2022
@kavilla
[1.x][Backwards Compatibility] restore URL forwarding from legacy app
9e92556 
Forwarding legacy app to the current format of the application.
This enables the usage of stored URLs and other links that referenced
the format of the application URL that mentioned the application name.

Since we changed the URL forwarding we changed this value and released.
So incase forks were made and depended on this legacy formatted reference
of the application. It will still work. There are also references of the
application.

Issue resolved:
#1013

Backport PR:
#1021

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this pull request Feb 10, 2022
@miukimiu @nickofthyme
style(crosshair): add z-index to crosshair line (opensearch-project#1021
497336e 
)

Co-authored-by: nickofthyme <nick.ryan.partridge@gmail.com>
@Flyingliuhub Flyingliuhub mentioned this pull request Apr 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmarkley tmarkley tmarkley approved these changes

@boktorbb boktorbb boktorbb approved these changes

@ananzh ananzh Awaiting requested review from ananzh ananzh is a code owner

@zuochengding zuochengding Awaiting requested review from zuochengding

Assignees
No one assigned
Labels
backwards-compatibility bug Something isn't working v1.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] app/kibana should foward to new format
3 participants
@kavilla @tmarkley @boktorbb