[Node.js upgrade] Skips flaky server metrics collector tests #1027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adds `--no-deprecation` flag for integration tests caused by `shot` which is a downstream dependency of `hapi`. * The ServerMetricsCollector tests are flaky and rely on the existing v17 hapi library that Dashboards depends on. This will be upgraded for the 2.0 release along with the Node.js upgrade. Signed-off-by: Tommy Markley <markleyt@amazon.com>
tmarkley
added
test:integration
build
tmarkley
changed the title
kavilla
reviewed
Dec 14, 2021
| @@ -42,7 +42,7 @@ | |||
| "opensearch": "node scripts/opensearch", | |||
| "test": "grunt test", | |||
| "test:jest": "node scripts/jest", | |||
| "test:jest_integration": "node scripts/jest_integration", | |||
| "test:jest_integration": "node --no-deprecation scripts/jest_integration", | |||
There was a problem hiding this comment.
What's the delta in tests after adding this? Like before change count and after change count.
There was a problem hiding this comment.
There shouldn't be a difference since the flag just ignores deprecation warnings. The tests don't run without it at this point.
|
Covered in #1028 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
--no-deprecationflag for integration tests caused byshotwhich is a downstream dependency of
hapi.v17 hapi library that Dashboards depends on. This will be upgraded
for the 2.0 release along with the Node.js upgrade.
Issues Resolved
Resolves #991
Check List
yarn test:jestyarn test:jest_integrationyarn test:ftr