Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node14 Complete upgrade #1034

Merged
merged 27 commits into from
Dec 17, 2021

Commits on Nov 5, 2021

  1. Fix Node selection when using built in node (opensearch-project#912)

    Fixed node selection to use the node executable instead of the user local node.  
    
    Issue resolved:
    opensearch-project#908
    
    Signed-off-by: Sven R <admin@hackacad.net>
    hackacad committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    bb6b925 View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2021

  1. [Release] add axios dependency to UI package

    This package was missing from release build so have to add it to this
    package.
    
    Brought in by custom branding.
    
    Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
    kavilla committed Nov 9, 2021
    Configuration menu
    Copy the full SHA
    ff84b35 View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2021

  1. Add support for codeowners to repo (opensearch-project#935)

    Signed-off-by: Ryan Bogan <rbogan@amazon.com>
    ryanbogan committed Nov 16, 2021
    Configuration menu
    Copy the full SHA
    48b372d View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2021

  1. [LIC] Allows the simplified header for new files (opensearch-project#936

    )
    
    * [LIC] Allows the simplified header for new files
    
    Signed-off-by: Ashwin Pc <ashwinpc@amazon.com>
    
    * Updates licence variable names
    
    Signed-off-by: Ashwin Pc <ashwinpc@amazon.com>
    
    Co-authored-by: Ashwin Pc <ashwinpc@amazon.com>
    ashwin-pc and ashwin-pc committed Nov 17, 2021
    Configuration menu
    Copy the full SHA
    8740e2a View commit details
    Browse the repository at this point in the history
  2. [Git] update PR template (opensearch-project#937)

    Update template to remove javadoc check box since we do not have any
    javadocs and include how to run the tests we use to verify the build.
    
    Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
    kavilla committed Nov 17, 2021
    Configuration menu
    Copy the full SHA
    4133cac View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2021

  1. Add release notes for Dashboards 1.2.0 (opensearch-project#944)

    This is the backport PR for opensearch-project#944
    
    Signed-off-by: Neumann <neumanns@amazon.com>
    seanneumann authored and kavilla committed Nov 18, 2021
    Configuration menu
    Copy the full SHA
    3d69c4f View commit details
    Browse the repository at this point in the history
  2. Add versioned document support in OSD

    This is PR is to add versioned document support in OSD.
    1. Add logic to pick up doc version from package.json and convert it to `latest` if we are on default `main` branch.
    2. Refactor doc_link_service to have 3 urls groups: opensearch, opensearchDashboards, and noDocumentation.
    3. Update dynamic versioned doc links and clean up unused urls
    4. Fix known url bug  opensearch-project#769
    5. Add unit tests for doclinks branch name conversion
    
    Signed-off-by: Zuocheng Ding <zding817@gmail.com>
    zuochengding committed Nov 18, 2021
    Configuration menu
    Copy the full SHA
    9047044 View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2021

  1. [Branding] prevent logging when config not set (opensearch-project#941)

    Out of the box, the rendering service will check the config
    and see the default value and log an info message saying that
    the branding config is invalid or not set. Everytime
    you refresh the browser you will get those log messages.
    
    This sets it to only log error messages if the user sets
    the branding config and it is invalid.
    
    Include using default messages.
    
    Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
    kavilla committed Nov 23, 2021
    Configuration menu
    Copy the full SHA
    86c202a View commit details
    Browse the repository at this point in the history
  2. [Version] Increment to 2.0 (opensearch-project#973)

    Version bump from 1.2 to 2.0
    
    Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
    kavilla committed Nov 23, 2021
    Configuration menu
    Copy the full SHA
    b8c5453 View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2021

  1. Add Lychee Link Checker into OSD (opensearch-project#938)

    1. Fix broken links in OSD
    2. Generate lycheeexcude list to filter out false negative warnings from test files or external links
    3. Add TODO items for internal unavaiable links
    4. Integrate with doc link service change.
    5. Standardize all opensearch url with `https://opensearch.org/` and add unavilable urls into noDocument list
    
    Signed-off-by: Zuocheng Ding <zding817@gmail.com>
    zuochengding committed Dec 8, 2021
    Configuration menu
    Copy the full SHA
    8c11eff View commit details
    Browse the repository at this point in the history

Commits on Dec 9, 2021

  1. Fix Lychee Link Checker Error (opensearch-project#1011)

    Signed-off-by: Zuocheng Ding <zding817@gmail.com>
    zuochengding committed Dec 9, 2021
    Configuration menu
    Copy the full SHA
    3ddaecb View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2021

  1. [CI] Add tests to github workflow

    Add unit tests to github workflow and also creating a "bad apples"
    environment variable. Some unit tests just fail on the CI for
    hardware issues. They should be improved but step one will be
    calling out the bad apples.
    
    Also due to the flakiness we can cache the previous run results
    and only run the tests that failed. It's too random to catch
    with the bad apples mechanism. But still added the continue on
    error for unit tests because it takes so long to re-run on the
    CI. So instead if it does fail we automatically echo there
    was a failure and ask them to re-run. However, if we can get
    permission for a github action that can add a comment to the PR
    then we could automatically add to PR.
    
    Next step will be improving.
    
    Also needed to limit the amount of workers because otherwise the
    hardware can't handle well so then it will accidentally create conflicts.
    This means we get an accurate test run but it is slower on the CI.
    
    Included integration tests which worked out of the box.
    
    Included e2e tests as well but it the chrome driver for the application
    was different from github's chrome so to run it I just upgraded it for
    the test run. Not ideal, ideally we should probably set up a
    docker env and install the specific versions since we are now
    depending on github's virtual env and the dependencies they installed
    there. But at least this is a first pace.
    
    Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
    kavilla committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    2d44dab View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2021

  1. Add bwc tests for osd with bundle (opensearch-project#871)

    tests include the following cases:
    verify default page work
    verify advanced savings work
    verify filter and query work
    
    Disable eslint check
    Add eslint-disable comment
    Revise license content in plugins and support
    Simplify filter and query test
    modify test name and fix PR comment
    update license header and remove env files
    fix timestamp issue
    update eslint and license
    
    Particailly Resolved:
    opensearch-project/opensearch-build#705
    
    Signed-off-by: Anan Zhuang <ananzh@amazon.com>
    ananzh committed Dec 15, 2021
    Configuration menu
    Copy the full SHA
    74eb00e View commit details
    Browse the repository at this point in the history
  2. Add more bwc tests for osd without bundles (opensearch-project#900)

    This PR adds the following bwc tests:
    1) verify sample data work properly for bwc
    2) verify timeline visualization work properly for bwc
    This PR also simplifies check_filter_and_query bwc test.
    It first removes Unique Visitors check because even fix
    the time interval, the number of unique visitors number
    is random. Then it simplifies this bwc test.
    
    add more tests in check_timeline and modify test names
    change one query content to make bwc tests more robust
    update license header
    add missing test and solve timestamp issue
    fix eslint and comments
    
    Partially Resolved:
    opensearch-project/opensearch-build#705
    
    Signed-off-by: Anan Zhuang <ananzh@amazon.com>
    ananzh committed Dec 15, 2021
    Configuration menu
    Copy the full SHA
    879cd33 View commit details
    Browse the repository at this point in the history
  3. Add bwc test data for osd without bundle (opensearch-project#927)

    This PR contains 13 zipped bwc test data for osd without bundle.
    The data has been tested by osd-1.1 and osd-1.2. To use, here are
    the steps:
    1)unzip the data to opensearch, for example:
    tar -xvf odfe-1.13.2.tar.gz
    You need to remove data folder first if there is one in opensearch
    2)run opensearch: ./bin/opensearch
    3)run dashboards: ./bin/opensearch-dashboards
    4)run any cypress test
    
    Partically Resolved:
    opensearch-project/opensearch-build#705
    
    Signed-off-by: Anan Zhuang <ananzh@amazon.com>
    ananzh committed Dec 15, 2021
    Configuration menu
    Copy the full SHA
    382ebe0 View commit details
    Browse the repository at this point in the history
  4. Add bwc test data for osd with bundle (opensearch-project#940)

    This PR contains 13 zipped bwc test data for osd with bundle.
    The data has been tested by osd-1.1 and osd-1.2. To use, here are
    the steps:
    1)unzip the data to opensearch, for example:
    tar -xvf odfe-1.13.2.tar.gz
    You need to remove data folder first if there is one in opensearch
    2)run opensearch: ./bin/opensearch
    3)run dashboards: ./bin/opensearch-dashboards
    4)run any cypress test
    
    Besides the above manual process, we now offer a script in this PR:
    opensearch-project#931
    
    To run bwc test using osd bundle data, use this command:
    ./cypress/bwctest-osd.sh
    -o /path/to/opensearch.tar.gz
    -d /path/to/opensearch-dashboards.tar.gz
    -b true
    
    Pls see more details in the above PR.
    
    fix data issue for eCommerse data
    resubmit data to fix timestamp issue
    
    Partically Resolved:
    opensearch-project/opensearch-build#705
    
    Signed-off-by: Anan Zhuang <ananzh@amazon.com>
    ananzh committed Dec 15, 2021
    Configuration menu
    Copy the full SHA
    160a7fd View commit details
    Browse the repository at this point in the history
  5. Add more bwc tests for osd with bundles (opensearch-project#901)

    This PR adds the following bwc tests:
    1)verify sample data work properly for bwc
    2)verify timeline visualization work properly for bwc
    
    add more commands check in check_timeline and rename sample data check
    minimize the login time and make the tests more robust
    change query content to make bwc test more robust
    update license header
    solve timestamp issue
    fix comments and eslint
    
    Partically Resolved:
    
    opensearch-project/opensearch-build#705
    
    Signed-off-by: Anan Zhuang <ananzh@amazon.com>
    ananzh committed Dec 15, 2021
    Configuration menu
    Copy the full SHA
    f665da3 View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2021

  1. [Backwards Compatibility] restore URL forwarding from legacy app

    Forwarding legacy app to the current format of the application.
    This enables the usage of stored URLs and other links that referenced
    the format of the application URL that mentioned the application name.
    
    Since we changed the URL forwarding we changed this value and released.
    So incase forks were made and depended on this legacy formatted reference
    of the application. It will still work. There are also references of the
    application.
    
    Issue resolved:
    opensearch-project#1013
    
    Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
    kavilla committed Dec 16, 2021
    Configuration menu
    Copy the full SHA
    b8f276f View commit details
    Browse the repository at this point in the history

Commits on Dec 17, 2021

  1. [draft] Node.js upgrade from 10 to 14

    * precommit checks are failing with an error related to an lmdb-store dependency
    * unit tests are failing with an error related to lmdb-store
    * bumped react from 16.12 to 16.14 to resolve unmet peer dependencies, but we still need a resolution to remove the old version
    * need a replacement for @elastic/good
    
    Signed-off-by: Bishoy Boktor <boktorbb@amazon.com>
    Tommy Markley authored and Bishoy Boktor committed Dec 17, 2021
    Configuration menu
    Copy the full SHA
    baa50c1 View commit details
    Browse the repository at this point in the history
  2. Adds transformIgnorePattern for lmdb-store and dependencies

    Signed-off-by: Bishoy Boktor <boktorbb@amazon.com>
    Bishoy Boktor committed Dec 17, 2021
    Configuration menu
    Copy the full SHA
    941820a View commit details
    Browse the repository at this point in the history
  3. Removes lmdb-store from transformIgnorePatterns and fixes unit test j…

    …est issues (opensearch-project#1012)
    
    Signed-off-by: Bishoy Boktor <boktorbb@amazon.com>
    boktorbb authored and Bishoy Boktor committed Dec 17, 2021
    Configuration menu
    Copy the full SHA
    dce8b19 View commit details
    Browse the repository at this point in the history
  4. [CI] Add tests to github workflow

    Add unit tests to github workflow and also creating a "bad apples"
    environment variable. Some unit tests just fail on the CI for
    hardware issues. They should be improved but step one will be
    calling out the bad apples.
    
    Also due to the flakiness we can cache the previous run results
    and only run the tests that failed. It's too random to catch
    with the bad apples mechanism. But still added the continue on
    error for unit tests because it takes so long to re-run on the
    CI. So instead if it does fail we automatically echo there
    was a failure and ask them to re-run. However, if we can get
    permission for a github action that can add a comment to the PR
    then we could automatically add to PR.
    
    Next step will be improving.
    
    Also needed to limit the amount of workers because otherwise the
    hardware can't handle well so then it will accidentally create conflicts.
    This means we get an accurate test run but it is slower on the CI.
    
    Included integration tests which worked out of the box.
    
    Included e2e tests as well but it the chrome driver for the application
    was different from github's chrome so to run it I just upgraded it for
    the test run. Not ideal, ideally we should probably set up a
    docker env and install the specific versions since we are now
    depending on github's virtual env and the dependencies they installed
    there. But at least this is a first pace.
    
    Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
    kavilla authored and Bishoy Boktor committed Dec 17, 2021
    Configuration menu
    Copy the full SHA
    48f3a69 View commit details
    Browse the repository at this point in the history
  5. Skips flaky server metrics collector tests

    * Adds `--no-deprecation` flag for integration tests caused by `shot`
    which is a downstream dependency of `hapi`.
    * The ServerMetricsCollector tests are flaky and rely on the existing
    v17 hapi library that Dashboards depends on. This will be upgraded
    for the 2.0 release along with the Node.js upgrade.
    
    Signed-off-by: Tommy Markley <markleyt@amazon.com>
    Tommy Markley authored and Bishoy Boktor committed Dec 17, 2021
    Configuration menu
    Copy the full SHA
    0e2bf03 View commit details
    Browse the repository at this point in the history
  6. Update node version in github workflow to 14

    Signed-off-by: Bishoy Boktor <boktorbb@amazon.com>
    Bishoy Boktor committed Dec 17, 2021
    Configuration menu
    Copy the full SHA
    883239a View commit details
    Browse the repository at this point in the history
  7. Bumps node to 14.18.2 and uses caret range for @types/node

    Signed-off-by: Bishoy Boktor <boktorbb@amazon.com>
    Bishoy Boktor committed Dec 17, 2021
    Configuration menu
    Copy the full SHA
    861ca16 View commit details
    Browse the repository at this point in the history
  8. Merge feature/node14

    Signed-off-by: Bishoy Boktor <boktorbb@amazon.com>
    Bishoy Boktor committed Dec 17, 2021
    Configuration menu
    Copy the full SHA
    fc3bd65 View commit details
    Browse the repository at this point in the history
  9. Fix local merge issues

    Signed-off-by: Bishoy Boktor <boktorbb@amazon.com>
    Bishoy Boktor committed Dec 17, 2021
    Configuration menu
    Copy the full SHA
    a7173de View commit details
    Browse the repository at this point in the history