Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Link] Fix yarnpkg link error #1037

Merged

Conversation

zuochengding
Copy link
Contributor

@zuochengding zuochengding commented Dec 21, 2021

Issue: https://yarnpkg.com/latest.msi is unavailable now and will be rerouted to a 404 page.

Signed-off-by: Zuocheng Ding zding817@gmail.com

Description

https://yarnpkg.com/latest.msi is unavailable now and will be rerouted to a 404 page.
Add it to link checker allow list to unblock the PR process.

Issues Resolved

Link checker error

Check List

  • New functionality includes testing.
    • All tests pass
      • yarn test:jest
      • yarn test:jest_integration
      • yarn test:ftr
  • New functionality has been documented.
  • Commits are signed per the DCO using --signoff

Issue: https://yarnpkg.com/latest.msi is unavailable now and will be rerouted to a 404 page.
Add it to link checker allow list to unblock the PR process.

Signed-off-by: Zuocheng Ding <zding817@gmail.com>
@zuochengding zuochengding self-assigned this Dec 21, 2021
@zuochengding zuochengding requested a review from a team as a code owner December 21, 2021 01:01
@kavilla
Copy link
Member

kavilla commented Dec 21, 2021

Do we need to do some research on the impact of this link failing since it was once working and now failing? I see it is used in a dist of osd-pm.

@kavilla kavilla merged commit 034ce71 into opensearch-project:main Dec 22, 2021
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this pull request Feb 10, 2022
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this pull request Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants