Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rename] newsfeed plug #117

Merged
merged 1 commit into from
Mar 11, 2021

Conversation

kavilla
Copy link
Member

@kavilla kavilla commented Mar 9, 2021

Signed-off-by: Kawika Avilla kavilla414@gmail.com

Issue #, if available:
#37

Description of changes:
Rename variables within plugins/timeline

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Copy link
Contributor

@seanneumann seanneumann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@mihirsoni mihirsoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !!

@boktorbb boktorbb merged commit 4bbda3e into opensearch-project:dashboards Mar 11, 2021
@kavilla kavilla deleted the rename-newsfeed branch March 18, 2021 08:05
kavilla referenced this pull request in kavilla/OpenSearch-Dashboards Mar 19, 2021
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
kavilla added a commit that referenced this pull request Mar 20, 2021
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
mihirsoni pushed a commit that referenced this pull request Mar 20, 2021
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Hailong-am added a commit to Hailong-am/OpenSearch-Dashboards that referenced this pull request Sep 1, 2023
* add workspace name duplication check

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* update error message

Signed-off-by: Hailong Cui <ihailong@amazon.com>

---------

Signed-off-by: Hailong Cui <ihailong@amazon.com>
SuZhou-Joe pushed a commit to SuZhou-Joe/OpenSearch-Dashboards that referenced this pull request Sep 14, 2023
* add workspace name duplication check

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* update error message

Signed-off-by: Hailong Cui <ihailong@amazon.com>

---------

Signed-off-by: Hailong Cui <ihailong@amazon.com>
Hailong-am added a commit to Hailong-am/OpenSearch-Dashboards that referenced this pull request Sep 15, 2023
* add workspace name duplication check

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* update error message

Signed-off-by: Hailong Cui <ihailong@amazon.com>

---------

Signed-off-by: Hailong Cui <ihailong@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants