-
Notifications
You must be signed in to change notification settings - Fork 912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename discover plugin (#37) #124
Rename discover plugin (#37) #124
Conversation
Signed-off-by: Bishoy Boktor <boktorbb@amazon.com>
</button> | ||
<% } %> | ||
</span> | ||
</td> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing new lines.
<icon ng-if="open" type="'arrowDown'" size="'s'"></icon> | ||
<icon ng-if="!open" type="'arrowRight'" size="'s'"></icon> | ||
</button> | ||
</td> | ||
</td> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing new lines.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple references to esFilters that should change.
src/plugins/discover/public/application/angular/directives/histogram.tsx
Show resolved
Hide resolved
Signed-off-by: Bishoy Boktor <boktorbb@amazon.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks!
* Rename discover plugin (#37) Signed-off-by: Bishoy Boktor <boktorbb@amazon.com>
…h-project#124) * Revert "[Refractor] Feature flag (opensearch-project#102)" This reverts commit e2f277c.
…h-project#124) * Revert "[Refractor] Feature flag (opensearch-project#102)" This reverts commit e2f277c.
…h-project#124) * Revert "[Refractor] Feature flag (opensearch-project#102)" This reverts commit e2f277c.
Signed-off-by: Bishoy Boktor boktorbb@amazon.com