Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename discover plugin (#37) #124

Merged
merged 2 commits into from
Mar 12, 2021
Merged

Rename discover plugin (#37) #124

merged 2 commits into from
Mar 12, 2021

Conversation

boktorbb
Copy link
Contributor

@boktorbb boktorbb commented Mar 9, 2021

Signed-off-by: Bishoy Boktor boktorbb@amazon.com

Signed-off-by: Bishoy Boktor <boktorbb@amazon.com>
</button>
<% } %>
</span>
</td>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing new lines.

<icon ng-if="open" type="'arrowDown'" size="'s'"></icon>
<icon ng-if="!open" type="'arrowRight'" size="'s'"></icon>
</button>
</td>
</td>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing new lines.

Copy link
Contributor

@mihirsoni mihirsoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !!

Copy link
Member

@kavilla kavilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple references to esFilters that should change.

Signed-off-by: Bishoy Boktor <boktorbb@amazon.com>
@boktorbb boktorbb requested a review from kavilla March 11, 2021 22:24
@boktorbb boktorbb dismissed kavilla’s stale review March 11, 2021 22:24

changes made

Copy link
Member

@kavilla kavilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@kavilla kavilla merged commit e0ea658 into opensearch-project:dashboards Mar 12, 2021
kavilla referenced this pull request in kavilla/OpenSearch-Dashboards Mar 19, 2021
* Rename discover plugin (#37)

Signed-off-by: Bishoy Boktor <boktorbb@amazon.com>
kavilla pushed a commit that referenced this pull request Mar 20, 2021
* Rename discover plugin (#37)

Signed-off-by: Bishoy Boktor <boktorbb@amazon.com>
mihirsoni pushed a commit that referenced this pull request Mar 20, 2021
* Rename discover plugin (#37)

Signed-off-by: Bishoy Boktor <boktorbb@amazon.com>
SuZhou-Joe pushed a commit to SuZhou-Joe/OpenSearch-Dashboards that referenced this pull request Sep 6, 2023
SuZhou-Joe pushed a commit to SuZhou-Joe/OpenSearch-Dashboards that referenced this pull request Sep 14, 2023
Hailong-am pushed a commit to Hailong-am/OpenSearch-Dashboards that referenced this pull request Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants