Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] update branch version to 1.3 #1333

Merged

Conversation

kavilla
Copy link
Member

@kavilla kavilla commented Mar 9, 2022

Description

branch in the package.json is used for pointing links to the right
site. For example: https://opensearch.org/docs/1.3/dashboards/index/.

NOTE: At the time this commit was made the doc site for 1.3, is
not available.

There is an existing issue here:
opensearch-project/documentation-website#296

We can point this to latest but the problem with that is that we
don't re-release versions. When the next major or minor release
occurs then latest will point to that version and now all
OpenSearch Dashboards 1.3 downloads will point to the newest version.

So to avoid that, I suggest we point this to 1.3 and I got confirmation
that it will be 1.3.

Signed-off-by: Kawika Avilla kavilla414@gmail.com

Issues Resolved

n/a

Check List

  • New functionality includes testing.
    • All tests pass
      • yarn test:jest
      • yarn test:jest_integration
      • yarn test:ftr
  • New functionality has been documented.
  • Commits are signed per the DCO using --signoff

`branch` in the package.json is used for pointing links to the right
site. For example: `https://opensearch.org/docs/1.3/dashboards/index/`.

NOTE: At the time this commit was made the doc site for `1.3`, is
not available.

There is an existing issue here:
opensearch-project/documentation-website#296

We can point this to `latest` but the problem with that is that we
don't re-release versions. When the next major or minor release
occurs then `latest` will point to that version and now all
OpenSearch Dashboards 1.3 downloads will point to the newest version.

So to avoid that, I suggest we point this to `1.3` and I got confirmation
that it will be `1.3`.

Issue resolved:
n/a

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
@kavilla kavilla requested review from ananzh and ashwin-pc March 9, 2022 00:28
@kavilla kavilla added v1.3.0 docs Improvements or additions to documentation labels Mar 9, 2022
Copy link
Member

@ashwin-pc ashwin-pc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

Copy link
Contributor

@mihirsoni mihirsoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !!

@kavilla kavilla merged commit 00e0693 into opensearch-project:1.x Mar 9, 2022
@kavilla kavilla deleted the avillk/1.x/bump_branch_version branch March 9, 2022 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation v1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants