Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rename] saved-objects-management plugin #136

Conversation

kavilla
Copy link
Member

@kavilla kavilla commented Mar 10, 2021

Signed-off-by: Kawika Avilla kavilla414@gmail.com

Issue #, if available:
#37

Description of changes:
Rename files and variables within plugins/saved-objects-management

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Contributor

@mihirsoni mihirsoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert the snapshot files and rest looks good to me.

Copy link
Contributor

@boktorbb boktorbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
@kavilla kavilla force-pushed the rename-saved-objects-management branch from f422140 to 963b39e Compare March 12, 2021 11:01
@kavilla kavilla requested a review from mihirsoni March 12, 2021 11:01
Copy link
Contributor

@mihirsoni mihirsoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@mihirsoni mihirsoni merged commit 5c08eab into opensearch-project:dashboards Mar 12, 2021
@kavilla kavilla deleted the rename-saved-objects-management branch March 18, 2021 08:01
kavilla referenced this pull request in kavilla/OpenSearch-Dashboards Mar 19, 2021
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
kavilla added a commit that referenced this pull request Mar 20, 2021
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
mihirsoni pushed a commit that referenced this pull request Mar 20, 2021
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
SuZhou-Joe pushed a commit to SuZhou-Joe/OpenSearch-Dashboards that referenced this pull request Sep 14, 2023
…roject#126) (opensearch-project#136)

(cherry picked from commit 56c8971)

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants