Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rename] legacy-export plugin #147

Merged

Conversation

kavilla
Copy link
Member

@kavilla kavilla commented Mar 10, 2021

Signed-off-by: Kawika Avilla kavilla414@gmail.com

Issue #, if available:
#37

Description of changes:
Rename files and variables within plugins/legacy_export.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Copy link
Contributor

@mihirsoni mihirsoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@boktorbb boktorbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@boktorbb boktorbb merged commit 409b37b into opensearch-project:dashboards Mar 11, 2021
@kavilla kavilla deleted the rename-legacy-export branch March 18, 2021 08:01
kavilla referenced this pull request in kavilla/OpenSearch-Dashboards Mar 19, 2021
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
kavilla added a commit that referenced this pull request Mar 20, 2021
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
mihirsoni pushed a commit that referenced this pull request Mar 20, 2021
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
raintygao pushed a commit to raintygao/OpenSearch-Dashboards that referenced this pull request Sep 15, 2023
…search-project#147)

* implement all duplicate copy modal



* add spacer after checkbox list



* add fail message for copy saved objects



* change title wording to manage library



* single duplicate



* change wording



* remove comment



* bug fix: keep selected saved objects info when cancel duplicate all



* fix typo



* use icu syntax in copy message



* bug fix: keep selected saved objects info when cancel duplicate single



* set current workspace as the first option



* update snapshot



* resolve conflict



* update snapshot



* bug fix for saved object table



* update snapshot



* remove unused file



* change i18n constant



* remove empty push



* hide duplicate when workspace is disabled



* update snapshots



---------


(cherry picked from commit 6231768)

Signed-off-by: yuye-aws <yuyezhu@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants