[Bug] fix missing discover context icon

[joshuarrrr]

Add back icon directive, which injects SVG for EUI icons

Signed-off-by: Josh Romero rmerqg@amazon.com

Description

Corrects rendering of discover context table row expansion buttons. The directive appears to have been removed when partially de-angularizing discover, without realizing the impact on the context doc table rendering.

Issues Resolved

fixes #1281

Check List

• New functionality includes testing.
  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
• New functionality has been documented.
• Commits are signed per the DCO using --signoff

[tmarkley]

Nice! Is it worthwhile to add tests to ensure the icons are now loaded properly to prevent a regression in the future?

[joshuarrrr]

Nice! Is it worthwhile to add tests to ensure the icons are now loaded properly to prevent a regression in the future?

Ideally, yes, absolutely.

The problem is I'm not sure there's a straightforward way to do that for these legacy views that are rendered with a mix of Angular and React. Specifically, the regression case we'd want to test is that we're dynamically inserting the icon SVG on any angular-defined <icon> state change so that

<icon ng-if="open" type="'arrowDown'" size="'s'" class="ng-scope"></icon>

becomes

<icon ng-if="open" type="'arrowDown'" size="'s'" class="ng-scope"><svg width="16" height="16" viewBox="0 0 16 16" xmlns="http://www.w3.org/2000/svg" class="euiIcon euiIcon--small" focusable="false" role="img" aria-hidden="true"><path fill-rule="non-zero" d="M13.069 5.157L8.384 9.768a.546.546 0 01-.768 0L2.93 5.158a.552.552 0 00-.771 0 .53.53 0 000 .759l4.684 4.61c.641.631 1.672.63 2.312 0l4.684-4.61a.53.53 0 000-.76.552.552 0 00-.771 0z"></path></svg></icon>

It probably makes more sense to spend some time investigating the functional tests in discover, to see if they provide enough coverage for the larger effort of finishing the migration from Angular to React.

[kavilla]

   __   _____________  ___
  / /  / ___/_  __/  |/  /
 / /__/ (_ / / / / /|_/ / 
/____/\___/ /_/ /_/  /_/  

[tmarkley]

It probably makes more sense to spend some time investigating the functional tests in discover, to see if they provide enough coverage for the larger effort of finishing the migration from Angular to React.

@joshuarrrr I think that's reasonable. We'll need to address that with #1560.