[CI][BWC] add BWC tests to github actions #1624

kavilla · 2022-05-25T23:05:09Z

Description

Add backwards compatibility tests to github workflow for PRs.
Also, fix for checking status of OpenSearch Dashboards since
api/status/ is not protected.

Also, enable ability to create test data since migration from
1.0.0 to 3.0.0 is not supported for OpenSearch currently.

Signed-off-by: Kawika Avilla kavilla414@gmail.com

Issues Resolved

#1465
#1651

Check List

.github/workflows/build_and_test_workflow.yml

codecov-commenter · 2022-05-25T23:57:03Z

Codecov Report

Merging #1624 (741a9ce) into main (665424e) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1624   +/-   ##
=======================================
  Coverage   68.08%   68.09%           
=======================================
  Files        3072     3072           
  Lines       59015    59015           
  Branches     8924     8924           
=======================================
+ Hits        40183    40187    +4     
+ Misses      16645    16642    -3     
+ Partials     2187     2186    -1

Impacted Files	Coverage Δ
...ic/application/models/sense_editor/sense_editor.ts	`64.88% <0.00%> (+0.88%)`	⬆️
...ared/static/forms/hook_form_lib/hooks/use_field.ts	`66.66% <0.00%> (+0.96%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 665424e...741a9ce. Read the comment docs.

joshuarrrr

Looks good to me, except that I think the instructions/docs could be a bit clearer. I'm still a bit confused about how the process of generating test data is supposed to work/be enforced.

Do we also need an update to https://github.com/opensearch-project/OpenSearch-Dashboards/blob/main/RELEASING.md, if generating test data should be done as part of a release? Or maybe just an update to the release issue templates.

TESTING.md

scripts/bwc/utils.sh

.github/workflows/build_and_test_workflow.yml

ananzh

nice 👍

Add backwards compatibility tests to github workflow for PRs. Also, fix for checking status of OpenSearch Dashboards since api/status/ is not protected. Also, enable ability to create test data since migration from 1.0.0 to 3.0.0 is not supported for OpenSearch currently. Issue: opensearch-project#1465 opensearch-project#1651 Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

joshuarrrr

A couple questions, but none that are blocking.

.github/workflows/build_and_test_workflow.yml

scripts/bwctest_osd.sh

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

ananzh

great research & cool piece

Add backwards compatibility tests to github workflow for PRs. Also, fix for checking status of OpenSearch Dashboards since api/status/ is not protected. Also, enable ability to create test data since migration from 1.0.0 to 3.0.0 is not supported for OpenSearch currently. Issue: opensearch-project#1465 opensearch-project#1651 Backport PR: opensearch-project#1624 Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

Add backwards compatibility tests to github workflow for PRs. Also, fix for checking status of OpenSearch Dashboards since api/status/ is not protected. Also, enable ability to create test data since migration from 1.0.0 to 3.0.0 is not supported for OpenSearch currently. Issue: opensearch-project#1465 opensearch-project#1651 Backport PR: opensearch-project#1624 Includes changes from: opensearch-project#1502 Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* [CI][BWC] add BWC tests to github actions (#1624) Add backwards compatibility tests to github workflow for PRs. Also, fix for checking status of OpenSearch Dashboards since api/status/ is not protected. Also, enable ability to create test data since migration from 1.0.0 to 3.0.0 is not supported for OpenSearch currently. Issue: #1465 #1651 Backport PR: #1624 Includes changes from: #1502 Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

…roject#1624) (opensearch-project#1659) [CI][BWC] add BWC tests to github actions (opensearch-project#1624) Add backwards compatibility tests to github workflow for PRs. Also, fix for checking status of OpenSearch Dashboards since api/status/ is not protected. Also, enable ability to create test data since migration from 1.0.0 to 3.0.0 is not supported for OpenSearch currently. Issue: opensearch-project#1465 opensearch-project#1651 Backport PR: opensearch-project#1624 Includes changes from: opensearch-project#1502 Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

… (#1675) [CI][BWC] add BWC tests to github actions (#1624) Add backwards compatibility tests to github workflow for PRs. Also, fix for checking status of OpenSearch Dashboards since api/status/ is not protected. Also, enable ability to create test data since migration from 1.0.0 to 3.0.0 is not supported for OpenSearch currently. Issue: #1465 #1651 Backport PR: #1624 Includes changes from: #1502 Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* [CI][BWC] add BWC tests to github actions Add backwards compatibility tests to github workflow for PRs. Also, fix for checking status of OpenSearch Dashboards since api/status/ is not protected. Also, enable ability to create test data since migration from 1.0.0 to 3.0.0 is not supported for OpenSearch currently. Issue: opensearch-project#1465 opensearch-project#1651 Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * Address comments Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

Changes originating from: opensearch-project#1624 This allows the workflow to run using the published images from: https://hub.docker.com/r/opensearchstaging/ci-runner/tags. To avoid the issues when GitHub virtual environments are updated. Issue: opensearch-project#1746 Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* [CI][BWC] add BWC tests to github actions Add backwards compatibility tests to github workflow for PRs. Also, fix for checking status of OpenSearch Dashboards since api/status/ is not protected. Also, enable ability to create test data since migration from 1.0.0 to 3.0.0 is not supported for OpenSearch currently. Issue: opensearch-project#1465 opensearch-project#1651 Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * Address comments Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

…roject#1624) (opensearch-project#1659) * [CI][BWC] add BWC tests to github actions (opensearch-project#1624) Add backwards compatibility tests to github workflow for PRs. Also, fix for checking status of OpenSearch Dashboards since api/status/ is not protected. Also, enable ability to create test data since migration from 1.0.0 to 3.0.0 is not supported for OpenSearch currently. Issue: opensearch-project#1465 opensearch-project#1651 Backport PR: opensearch-project#1624 Includes changes from: opensearch-project#1502 Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

joshuarrrr reviewed May 25, 2022

View reviewed changes

.github/workflows/build_and_test_workflow.yml Show resolved Hide resolved

kavilla force-pushed the avillk/github/bwc_tests branch 3 times, most recently from a9aeea6 to b0e4018 Compare May 29, 2022 06:21

kavilla linked an issue May 29, 2022 that may be closed by this pull request

[CI] hook PR workflow into BWC tests #1465

Closed

kavilla added ci test:bwc v3.0.0 labels May 29, 2022

kavilla marked this pull request as ready for review May 29, 2022 06:24

kavilla requested a review from a team as a code owner May 29, 2022 06:24

joshuarrrr reviewed May 31, 2022

View reviewed changes

TESTING.md Outdated Show resolved Hide resolved

scripts/bwc/utils.sh Show resolved Hide resolved

ananzh reviewed May 31, 2022

View reviewed changes

.github/workflows/build_and_test_workflow.yml Show resolved Hide resolved

.github/workflows/build_and_test_workflow.yml Show resolved Hide resolved

kavilla force-pushed the avillk/github/bwc_tests branch from b0e4018 to 7008596 Compare June 1, 2022 01:24

kavilla requested review from ananzh and joshuarrrr June 1, 2022 01:24

ananzh previously approved these changes Jun 1, 2022

View reviewed changes

kavilla dismissed ananzh’s stale review via aad87b8 June 2, 2022 05:27

kavilla force-pushed the avillk/github/bwc_tests branch 5 times, most recently from 77c74ef to 1a0becc Compare June 2, 2022 07:20

kavilla force-pushed the avillk/github/bwc_tests branch from aea6e2f to a30510e Compare June 2, 2022 08:24

kavilla mentioned this pull request Jun 2, 2022

Use opensearch-builds CI runner for functional tests #1651

Open

joshuarrrr reviewed Jun 2, 2022

View reviewed changes

.github/workflows/build_and_test_workflow.yml Show resolved Hide resolved

scripts/bwctest_osd.sh Outdated Show resolved Hide resolved

Address comments

6af85d2

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

kavilla force-pushed the avillk/github/bwc_tests branch from fe30eac to 6af85d2 Compare June 2, 2022 17:37

kavilla requested a review from joshuarrrr June 2, 2022 17:45

kavilla requested a review from ananzh June 2, 2022 17:46

ananzh approved these changes Jun 2, 2022

View reviewed changes

ashwin-pc approved these changes Jun 2, 2022

View reviewed changes

joshuarrrr approved these changes Jun 2, 2022

View reviewed changes

ashwin-pc merged commit 35eeb76 into opensearch-project:main Jun 2, 2022

kavilla added the needs-documentation label Jun 2, 2022

kavilla mentioned this pull request Jun 2, 2022

[Backport 2.x][CI][BWC] add BWC tests to github actions (#1624) #1659

Merged

kavilla mentioned this pull request Jun 3, 2022

[Backport 2.0][CI][BWC] add BWC tests to github actions (#1624) (#1659) #1675

Merged

tmarkley added v2.1.0 v2.0.1 labels Jun 14, 2022

kavilla mentioned this pull request Jun 14, 2022

[CI] Backport CI workflows to 1.x branches #1746

Closed

kavilla mentioned this pull request Jun 15, 2022

[CI][Github] Use OpenSearch Docker Image #1751

Closed

7 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CI][BWC] add BWC tests to github actions #1624

[CI][BWC] add BWC tests to github actions #1624

kavilla commented May 25, 2022 •

edited

Loading

codecov-commenter commented May 25, 2022 •

edited

Loading

joshuarrrr left a comment

ananzh left a comment

joshuarrrr left a comment

ananzh left a comment

[CI][BWC] add BWC tests to github actions #1624

[CI][BWC] add BWC tests to github actions #1624

Conversation

kavilla commented May 25, 2022 • edited Loading

Description

Issues Resolved

Check List

codecov-commenter commented May 25, 2022 • edited Loading

Codecov Report

joshuarrrr left a comment

Choose a reason for hiding this comment

ananzh left a comment

Choose a reason for hiding this comment

joshuarrrr left a comment

Choose a reason for hiding this comment

ananzh left a comment

Choose a reason for hiding this comment

kavilla commented May 25, 2022 •

edited

Loading

codecov-commenter commented May 25, 2022 •

edited

Loading