Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rename] timelion to timeline (#37) #186

Merged
merged 1 commit into from
Mar 18, 2021
Merged

[Rename] timelion to timeline (#37) #186

merged 1 commit into from
Mar 18, 2021

Conversation

boktorbb
Copy link
Contributor

Signed-off-by: Bishoy Boktor boktorbb@amazon.com

Signed-off-by: Bishoy Boktor <boktorbb@amazon.com>
@odfe-release-bot
Copy link

✅   DCO Check Passed

Copy link
Contributor

@mihirsoni mihirsoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !!

@kavilla
Copy link
Member

kavilla commented Mar 18, 2021

LGTM, runs fine. Just linter fails for 12 errors but just needs rebasing so it might not be worth it.

@boktorbb boktorbb merged commit 3340767 into opensearch-project:dashboards Mar 18, 2021
kavilla referenced this pull request in kavilla/OpenSearch-Dashboards Mar 19, 2021
Signed-off-by: Bishoy Boktor <boktorbb@amazon.com>
kavilla pushed a commit that referenced this pull request Mar 20, 2021
Signed-off-by: Bishoy Boktor <boktorbb@amazon.com>
mihirsoni pushed a commit that referenced this pull request Mar 20, 2021
Signed-off-by: Bishoy Boktor <boktorbb@amazon.com>
wanglam pushed a commit to wanglam/OpenSearch-Dashboards that referenced this pull request Sep 26, 2023
…arch-project#186)

* Support to display workspace feature configured with wildcard

1. In workspace update page, support to display workspace feature
configured with wildcard.

2. Fixed an issue which generateWorkspacePermissionError return void

3. Fixed an issue which workspace route validation failed due to missing
   permission mode in schema

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>

* update dependence array

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>

---------

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
Hailong-am pushed a commit to Hailong-am/OpenSearch-Dashboards that referenced this pull request Oct 9, 2023
…arch-project#186)

* Support to display workspace feature configured with wildcard

1. In workspace update page, support to display workspace feature
configured with wildcard.

2. Fixed an issue which generateWorkspacePermissionError return void

3. Fixed an issue which workspace route validation failed due to missing
   permission mode in schema

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>

* update dependence array

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>

---------

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants