Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rename] .opensearch-dashboards index to .opensearch_dashboards (#37) #188

Merged
merged 3 commits into from
Mar 18, 2021
Merged

Conversation

boktorbb
Copy link
Contributor

Signed-off-by: Bishoy Boktor boktorbb@amazon.com

@odfe-release-bot
Copy link

✅   DCO Check Passed

scripts/README.md Outdated Show resolved Hide resolved
@odfe-release-bot
Copy link

✅   DCO Check Passed

Copy link
Member

@kavilla kavilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the comment about opensearch_dashboards-test. LGTM

@odfe-release-bot
Copy link

✅   DCO Check Passed

Copy link
Contributor

@mihirsoni mihirsoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !!

Bishoy Boktor added 3 commits March 18, 2021 23:42
Signed-off-by: Bishoy Boktor <boktorbb@amazon.com>
Signed-off-by: Bishoy Boktor <boktorbb@amazon.com>
Signed-off-by: Bishoy Boktor <boktorbb@amazon.com>
@odfe-release-bot
Copy link

✅   DCO Check Passed

@boktorbb boktorbb merged commit af5f643 into opensearch-project:dashboards Mar 18, 2021
kavilla referenced this pull request in kavilla/OpenSearch-Dashboards Mar 19, 2021
… (#188)

* [Rename] .opensearch-dashboards index to .opensearch_dashboards (#37)

Signed-off-by: Bishoy Boktor <boktorbb@amazon.com>

* Address PR comments

Signed-off-by: Bishoy Boktor <boktorbb@amazon.com>

* Address PR comments

Signed-off-by: Bishoy Boktor <boktorbb@amazon.com>
kavilla pushed a commit that referenced this pull request Mar 20, 2021
…#188)

* [Rename] .opensearch-dashboards index to .opensearch_dashboards (#37)

Signed-off-by: Bishoy Boktor <boktorbb@amazon.com>

* Address PR comments

Signed-off-by: Bishoy Boktor <boktorbb@amazon.com>

* Address PR comments

Signed-off-by: Bishoy Boktor <boktorbb@amazon.com>
mihirsoni pushed a commit that referenced this pull request Mar 20, 2021
…#188)

* [Rename] .opensearch-dashboards index to .opensearch_dashboards (#37)

Signed-off-by: Bishoy Boktor <boktorbb@amazon.com>

* Address PR comments

Signed-off-by: Bishoy Boktor <boktorbb@amazon.com>

* Address PR comments

Signed-off-by: Bishoy Boktor <boktorbb@amazon.com>
Hailong-am added a commit to Hailong-am/OpenSearch-Dashboards that referenced this pull request Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants