[Backport 2.x] Add DocView links pluggable injection capability #1891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
* Add DocView links pluggable injection capability * Add proper e2e + bugfix * set prop as lower case * Better name * Delete prop after usage * Camel case + avoid mutating * Added right data-test-subj in order to fix tests * update snapshot * Add hide prop in order to mimic ng-if condition * Add i18n translation support * Fix tests * Made text smaller + used eui components instead of custom css * Snapshots Signed-off-by: sitbubu <royi.sitbon@logz.io> Signed-off-by: Royi Sitbon <royi.sitbon@logz.io> (cherry picked from commit c33bf8c)
kavilla
force-pushed
the
backport/backport-1200-to-2.x
branch
from
ec213b7 to
8b846f3
Compare
kavilla
approved these changes
Jul 14, 2022
joshuarrrr
approved these changes
Jul 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport c33bf8c from #1200