[Rename] all elastic github references except for issues and PRs (#37) #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ DCO Check Passed |
Signed-off-by: Bishoy Boktor <boktorbb@amazon.com>
|
✅ DCO Check Passed |
ananzh
approved these changes
Mar 19, 2021
kavilla
previously requested changes
Mar 19, 2021
| @@ -272,7 +272,7 @@ The tests cover: | |||
| - authenticated / non-authenticated user access (when applicable) | |||
|
|
|||
| ```typescript | |||
| // TODO after https://github.com/elastic/opensearch-dashboards/pull/53208/ | |||
| // TODO after https://github.com/elastic/kibana/pull/53208/ | |||
|
Mostly good just that conflict was committed |
Signed-off-by: Bishoy Boktor <boktorbb@amazon.com>
|
✅ DCO Check Passed |
kavilla
referenced
this pull request
in kavilla/OpenSearch-Dashboards
Mar 19, 2021
…) (#200) * [Rename] all elastic github references except for issues and PRs (#37) Signed-off-by: Bishoy Boktor <boktorbb@amazon.com> * Address PR comments Signed-off-by: Bishoy Boktor <boktorbb@amazon.com>
kavilla
pushed a commit
that referenced
this pull request
Mar 20, 2021
mihirsoni
pushed a commit
that referenced
this pull request
Mar 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Bishoy Boktor boktorbb@amazon.com